Closed
Bug 1041571
Opened 11 years ago
Closed 11 years ago
Add some basic leak testing for nsSystemStatusBarCocoa
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file)
|
4.27 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
There's currently no test coverage of nsSystemStatusBarCocoa, so we don't even benefit from leak checking (which is done automatically in test runs with debug builds). Adding some basic test coverage is simple enough that there's really no excuse not to do it.
|
Assignee | |
Comment 1•11 years ago
|
||
This test can be run locally using
mach mochitest widget/tests/test_system_status_bar.xul
Attachment #8459630 -
Flags: review?(smichaud)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8459630 [details] [diff] [review]
v1
Looks fine to me.
Attachment #8459630 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•