Closed
Bug 1041607
Opened 11 years ago
Closed 11 years ago
Remove synchronous XHR from tests
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Looks like some platform bug landed recently which prevents us from using synchronous XHR inside of an exec script.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8459664 [details] [review]
Github pull request
Amir - could you give me a hand in review here? It should resolve your test failures. Thanks!
Attachment #8459664 -
Flags: review?(amirn)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8459664 [details] [review]
Github pull request
LGTM. Thanks.
Attachment #8459664 -
Flags: review?(amirn) → review+
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Amir Nissim (:amirn) from comment #3)
> Comment on attachment 8459664 [details] [review]
> Github pull request
>
> LGTM. Thanks.
Thanks. These tests all passed for me locally, so let's land it to unblock you.
Master: https://github.com/mozilla-b2g/gaia/commit/649245c238a043af32acb109b2613f578323f8e1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•