Closed Bug 1041607 Opened 10 years ago Closed 10 years ago

Remove synchronous XHR from tests

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S1 (1aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
amirn
: review+
Details | Review 
Looks like some platform bug landed recently which prevents us from using synchronous XHR inside of an exec script.
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8459664 [details] [review]
Github pull request

Amir - could you give me a hand in review here? It should resolve your test failures. Thanks!

        Attachment #8459664 -
        Flags: review?(amirn)

    
    

    
  
Comment on attachment 8459664 [details] [review]
Github pull request

LGTM. Thanks.

        Attachment #8459664 -
        Flags: review?(amirn) → review+
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]

    
    

    
  
(In reply to Amir Nissim (:amirn) from comment #3)
> Comment on attachment 8459664 [details] [review]
> Github pull request
> 
> LGTM. Thanks.

Thanks. These tests all passed for me locally, so let's land it to unblock you. 

Master: https://github.com/mozilla-b2g/gaia/commit/649245c238a043af32acb109b2613f578323f8e1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: