Closed
Bug 1041687
Opened 10 years ago
Closed 10 years ago
replace place holder screensharing icons with final icons
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
|
83.76 KB,
patch
|
Dolske
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Once we have the final icons from bug 1037418, we should use them.
Flags: firefox-backlog+
|
||
Comment 1•10 years ago
|
||
Hi Florian, can you mark this bug as either [qa+] or [qa-] for verification.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Iteration: --- → 34.1
QA Whiteboard: [qa?]
Flags: needinfo?(florian)
|
Assignee | |
Updated•10 years ago
|
QA Whiteboard: [qa?] → [qa+]
Flags: needinfo?(florian)
|
||
Updated•10 years ago
|
Whiteboard: [sceensharing-uplift]
|
||
Updated•10 years ago
|
QA Contact: drno
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8464848 -
Flags: review?(dolske)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8464848 [details] [diff] [review]
Patch
Review of attachment 8464848 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #8464848 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
|
Assignee | |
Comment 6•10 years ago
|
||
Comment on attachment 8464848 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: bug 1037405
[User impact if declined]: the screensharing UI will have placeholder icons instead of the final one approved by UX.
[Describe test coverage new/current, TBPL]: currently on m-c, will be verified by QA
[Risks and why]: low, icon change only.
[String/UUID change made/needed]: none.
Attachment #8464848 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•10 years ago
|
Iteration: 34.1 → 34.2
|
||
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox34:
--- → fixed
|
|
||
Updated•10 years ago
|
Attachment #8464848 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
||
Updated•10 years ago
|
QA Contact: drno → florin.mezei
|
||
Updated•10 years ago
|
QA Contact: florin.mezei → paul.silaghi
|
||
Comment 8•10 years ago
|
||
The icons look ok, tested on 34.0a1 (2014-08-13), 33.0a2 (2014-08-13) Win 7, Ubuntu 13.04, OS X 10.8.5
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
|
||
Updated•10 years ago
|
Whiteboard: [sceensharing-uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•