Closed Bug 1041687 Opened 6 years ago Closed 6 years ago

replace place holder screensharing icons with final icons

Categories

(Firefox :: Theme, defect)

defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.2
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Once we have the final icons from bug 1037418, we should use them.
Flags: firefox-backlog+
Hi Florian, can you mark this bug as either [qa+] or [qa-] for verification.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Iteration: --- → 34.1
QA Whiteboard: [qa?]
Flags: needinfo?(florian)
QA Whiteboard: [qa?] → [qa+]
Flags: needinfo?(florian)
Blocks: 1040061
Whiteboard: [sceensharing-uplift]
Attached patch PatchSplinter Review
Attachment #8464848 - Flags: review?(dolske)
Comment on attachment 8464848 [details] [diff] [review]
Patch

Review of attachment 8464848 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8464848 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/9f2acd025609
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8464848 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1037405
[User impact if declined]: the screensharing UI will have placeholder icons instead of the final one approved by UX.
[Describe test coverage new/current, TBPL]: currently on m-c, will be verified by QA
[Risks and why]: low, icon change only.
[String/UUID change made/needed]: none.
Attachment #8464848 - Flags: approval-mozilla-aurora?
Iteration: 34.1 → 34.2
Attachment #8464848 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Contact: drno → florin.mezei
QA Contact: florin.mezei → paul.silaghi
The icons look ok, tested on 34.0a1 (2014-08-13), 33.0a2 (2014-08-13) Win 7, Ubuntu 13.04, OS X 10.8.5
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Whiteboard: [sceensharing-uplift]
You need to log in before you can comment on or make changes to this bug.