1041687 - replace place holder screensharing icons with final icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Florian Quèze [:florian]]

Once we have the final icons from bug 1037418, we should use them.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Florian, can you mark this bug as either [qa+] or [qa-] for verification.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 8464848 [details] [diff] [review]
Patch

Review of attachment 8464848 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/9f2acd025609

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f2acd025609

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8464848 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1037405
[User impact if declined]: the screensharing UI will have placeholder icons instead of the final one approved by UX.
[Describe test coverage new/current, TBPL]: currently on m-c, will be verified by QA
[Risks and why]: low, icon change only.
[String/UUID change made/needed]: none.

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/27bf19b959fc

Comment 8

[Paul Silaghi, QA [:pauly]]

The icons look ok, tested on 34.0a1 (2014-08-13), 33.0a2 (2014-08-13) Win 7, Ubuntu 13.04, OS X 10.8.5