Closed Bug 1041709 Opened 11 years ago Closed 11 years ago

Convert search to use function score queries

Categories

(Marketplace Graveyard :: Search, defect, P2)

Product:
Marketplace Graveyard
Component:
Search
Version:
Avenir
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-08-12

People

(Reporter: robhudson, Assigned: robhudson)

References

Details

This needs to happen when we upgrade to Elasticsearch 1.0+. See: https://github.com/mozilla/zamboni/blob/master/mkt/search/views.py#L127-L131 There are also a couple changes to count queries that change after 1.0+ that are only used in tests in mkt/webapps/tests/test_models.py.
Assignee: nobody → robhudson.mozbugs
Perhaps also update documentation that we can now use homebrew installed Elasticsearch, or point to a newer version.
Depends on: 971801
Priority: -- → P2
This ended up being more of an update everything for 1.0+ bug: https://github.com/mozilla/zamboni/compare/b2f5b21a9b49...ad6a7925da8e For QA ensure common searching works as expected and pay close attention to search relevancy as this changed between Elasticsearch versions and has been rewritten. The "popular" and "new" pages should work fine, but more importantly search queries should roughly match the order on prod (assuming the install counts are equivalent).
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-08-12
Rob, I am not sure that I correctly understand this sentence : "search queries should roughly match the order on prod (assuming the install counts are equivalent)." . Can you please provide more info in order to be sure that I am verifying this with correct steps?
Flags: needinfo?(robhudson.mozbugs)
After talking with Rob on IRC, I observed that the results between -dev and prod are different. Even if the first three results are the same , we can see that the order of next results is different for apps present on both servers : MP-dev : http://screencast.com/t/bqTkULtQ5Lp Prod : http://screencast.com/t/Vkd222ZfKt
Status: RESOLVED → REOPENED
Flags: needinfo?(robhudson.mozbugs)
Resolution: FIXED → ---
After taking a look I think this is fine. It's not going to be exact since it depends on number of app installs which would have drifted apart since the database copy. If it's generally the same that's enough to know the scoring is working otherwise they'd be pretty different.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Verified as fixed in https://marketplace-dev.allizom.org/search?q=game and https://marketplace.firefox.com/search?q=game Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.