Closed
Bug 1041730
Opened 7 years ago
Closed 7 years ago
Unused time parameters in some functions in PublicKeyPinningService.cpp
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file, 1 obsolete file)
2.89 KB,
patch
|
cviecco
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8459774 -
Flags: review?(cviecco)
Comment 1•7 years ago
|
||
Comment on attachment 8459774 [details] [diff] [review] remove-unused-params-Pinning.patch Review of attachment 8459774 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/manager/boot/src/PublicKeyPinningService.cpp @@ +295,5 @@ > { > if (!certList) { > return false; > } > + if (time > TimeFromElapsedSecondsAD(kPreloadPKPinsExpirationTime)) { This seems to depend on TimeFromElapsedSecondsAD that is not on mxr. Is there another patch?
Attachment #8459774 -
Flags: review?(cviecco) → review-
Assignee | ||
Comment 2•7 years ago
|
||
Thanks Camilo. I updated the patch to split out the unrelated changes.
Attachment #8459774 -
Attachment is obsolete: true
Attachment #8459980 -
Flags: review?(cviecco)
Updated•7 years ago
|
Attachment #8459980 -
Flags: review?(cviecco) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for the quick reviews!: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c212e1705f7
https://hg.mozilla.org/mozilla-central/rev/9c212e1705f7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
QA Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•