1041730 - Unused time parameters in some functions in PublicKeyPinningService.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: remove-unused-params-Pinning.patch

Comment 1

[Camilo Viecco (:cviecco)]

Comment on attachment 8459774 [details] [diff] [review]
remove-unused-params-Pinning.patch

Review of attachment 8459774 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/boot/src/PublicKeyPinningService.cpp
@@ +295,5 @@
>  {
>    if (!certList) {
>      return false;
>    }
> +  if (time > TimeFromElapsedSecondsAD(kPreloadPKPinsExpirationTime)) {

This seems to depend on TimeFromElapsedSecondsAD that is not on mxr. Is there another patch?

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: remove-unused-params-Pinning.patch [v2]

Thanks Camilo. I updated the patch to split out the unrelated changes.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Thanks for the quick reviews!:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c212e1705f7

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c212e1705f7