1041770 - JavaScript Error: "win is undefined" {file: "chrome://browser/content/browser.js" line: 5978}

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Nick Alexander :nalexander [he/him]]

http://hg.mozilla.org/mozilla-central/rev/53f37bbfd7ab

did not update the reference to originatingWindow at 

http://hg.mozilla.org/mozilla-central/annotate/0dc711216018/mobile/android/chrome/content/browser.js#l5996

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Update missed reference. r=mrbkap

This was oversight from the landing of Bug 952201.  It manifested as:

E GeckoConsole(5812)          [JavaScript Error: "win is undefined" {file: "chrome://browser/content/browser.js" line: 5978}]

when trying to install a blocked add-on.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Review of attachment 8459829 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

I talked to Nick on IRC about the fact that this would have to change if Firefox for Android ever becomes multiprocess (in which case the originator would be whatever we target IPC messages to for frame message managers, that would be the <browser remote=true> in Desktop Firefox), but apparently we have no plans to make such a change.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Oh, and thanks for cleaning up my mess here!

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/b5dbedb3dead

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5dbedb3dead

Comment 6

[Rob Wu [:robwu]]

Could this fix be backported to 33?

I've just spent hours on trying to install a Firefox addon on my Android phone, without luck... I've tried visiting the xpi URL, using InstallTrigger, uploading the xpi to my sdcard, putting the xpi in the extensions/ directory, and none of the methods worked.

How can I install a Firefox addon in Firefox Beta (33) while this bug is not fixed?

Comment 7

[Nick Alexander :nalexander [he/him]]

(In reply to Rob W from comment #6)
> Could this fix be backported to 33?
> 
> I've just spent hours on trying to install a Firefox addon on my Android
> phone, without luck... I've tried visiting the xpi URL, using
> InstallTrigger, uploading the xpi to my sdcard, putting the xpi in the
> extensions/ directory, and none of the methods worked.
> 
> How can I install a Firefox addon in Firefox Beta (33) while this bug is not
> fixed?

Yeah, that's reasonable.  Requesting uplift.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Approval Request Comment
[Feature/regressing bug #]: Bug 952201.

[User impact if declined]: see previous comment.

[Describe test coverage new/current, TBPL]: none.  It's been in the wild for ... 6 weeks?

[Risks and why]: essentially none.  We're already busted.

[String/UUID change made/needed]: None.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Beta+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40044a225ae7