Closed Bug 1041770 Opened 5 years ago Closed 5 years ago

JavaScript Error: "win is undefined" {file: "chrome://browser/content/browser.js" line: 5978}

Categories

(Firefox :: Extension Compatibility, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 34
Tracking Status
firefox32 --- unaffected
firefox33 + fixed
firefox34 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

This was oversight from the landing of Bug 952201.  It manifested as:

E GeckoConsole(5812)          [JavaScript Error: "win is undefined" {file: "chrome://browser/content/browser.js" line: 5978}]

when trying to install a blocked add-on.
Attachment #8459829 - Flags: review?(mrbkap)
Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Review of attachment 8459829 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

I talked to Nick on IRC about the fact that this would have to change if Firefox for Android ever becomes multiprocess (in which case the originator would be whatever we target IPC messages to for frame message managers, that would be the <browser remote=true> in Desktop Firefox), but apparently we have no plans to make such a change.
Attachment #8459829 - Flags: review?(mrbkap) → review+
Oh, and thanks for cleaning up my mess here!
https://hg.mozilla.org/integration/fx-team/rev/b5dbedb3dead
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/b5dbedb3dead
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
Could this fix be backported to 33?

I've just spent hours on trying to install a Firefox addon on my Android phone, without luck... I've tried visiting the xpi URL, using InstallTrigger, uploading the xpi to my sdcard, putting the xpi in the extensions/ directory, and none of the methods worked.

How can I install a Firefox addon in Firefox Beta (33) while this bug is not fixed?
(In reply to Rob W from comment #6)
> Could this fix be backported to 33?
> 
> I've just spent hours on trying to install a Firefox addon on my Android
> phone, without luck... I've tried visiting the xpi URL, using
> InstallTrigger, uploading the xpi to my sdcard, putting the xpi in the
> extensions/ directory, and none of the methods worked.
> 
> How can I install a Firefox addon in Firefox Beta (33) while this bug is not
> fixed?

Yeah, that's reasonable.  Requesting uplift.
Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Approval Request Comment
[Feature/regressing bug #]: Bug 952201.

[User impact if declined]: see previous comment.

[Describe test coverage new/current, TBPL]: none.  It's been in the wild for ... 6 weeks?

[Risks and why]: essentially none.  We're already busted.

[String/UUID change made/needed]: None.
Attachment #8459829 - Flags: approval-mozilla-beta?
Comment on attachment 8459829 [details] [diff] [review]
Update missed reference. r=mrbkap

Beta+
Attachment #8459829 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.