1041868 - AsmJSActivation compile error on non-ion builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Singer (:stevensn)]

non-ion builds are failing because the AsmJSActivation constructor is calling methods on module (AsmJSModule) which is only defined with JS_ION


From http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1809/steps/shell/logs/stdio

 2:08.29 In file included from /home/buildbot/buildbot/slave/runtests/build/obj-powerpc64-unknown-linux-gnu/js/src/Unified_cpp_js_src6.cpp:54:0:
 2:08.29 /home/buildbot/buildbot/slave/runtests/build/js/src/vm/Stack.cpp: In constructor ‘js::AsmJSActivation::AsmJSActivation(JSContext*, js::AsmJSModule&)’:
 2:08.29 /home/buildbot/buildbot/slave/runtests/build/js/src/vm/Stack.cpp:1704:33: error: invalid use of incomplete type ‘class js::AsmJSModule’

Comment 1

[Steve Singer (:stevensn)]

Attachment: ifdef_asmjsmodule.diff

Comment 2

[Steve Singer (:stevensn)]

Comment on attachment 8459996 [details] [diff] [review]
ifdef_asmjsmodule.diff

This patch isn't sufficient.
I still get link time errors that look related.

libjs_static.a(Unified_cpp_js_src6.o): In function `JS::ProfilingFrameIterator::ProfilingFrameIterator(JSRuntime*, JS::ProfilingFrameIterator::RegisterState const&)':
64:44.70 /media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/js/src/vm/Stack.cpp:1789: undefined reference to `js::AsmJSProfilingFrameIterator::AsmJSProfilingFrameIterator(js::AsmJSActivation const&, JS::ProfilingFrameIterator::RegisterState const&)'

among others

Comment 3

[Luke Wagner [:luke]]

Attachment: fix-no-ion

Oops, sorry, this should fix it.  Waiting for tree to open...

Comment 4

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f604cdbc6e85

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f604cdbc6e85