Closed Bug 1041881 Opened 5 years ago Closed 5 years ago

NS_NewNonOwningRunnableMethod expects a pointer as first argument but it shouldn't

Categories

(Core :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: atifrea, Assigned: mrbkap)

Details

Attachments

(1 file)

NS_NewNonOwningRunnableMethod should expect the actual value not a pointer to that value as argument. I came across this issue while working on bug 1015466.
This bug is somewhat related to bug 1041877.
Attached patch patchSplinter Review
Understanding this patch completely requires understanding the relationship between template pattern matching and rvalue references.  Basically this patch makes us take smart pointers by reference.
Attachment #8460584 - Flags: review?(khuey)
Assignee: nobody → mrbkap
https://hg.mozilla.org/mozilla-central/rev/c17c9910cc2e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.