Closed
Bug 1041881
Opened 10 years ago
Closed 10 years ago
NS_NewNonOwningRunnableMethod expects a pointer as first argument but it shouldn't
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: atifrea, Assigned: mrbkap)
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
NS_NewNonOwningRunnableMethod should expect the actual value not a pointer to that value as argument. I came across this issue while working on bug 1015466. This bug is somewhat related to bug 1041877.
|
Assignee | |
Comment 1•10 years ago
|
||
Understanding this patch completely requires understanding the relationship between template pattern matching and rvalue references. Basically this patch makes us take smart pointers by reference.
Attachment #8460584 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mrbkap
Attachment #8460584 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c17c9910cc2e
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c17c9910cc2e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•