Closed Bug 1042003 Opened 10 years ago Closed 10 years ago

Audio Offload Playback is resuming from the beginning when the device is switched from headset to BT.

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- wontfix
firefox34 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: vasanth, Assigned: vasanth, NeedInfo)

References

(
URL
)

Details

(Whiteboard: [caf priority: p2][CR 693996])

Attachments

(1 file)

Convert-secs-to-usecs.patch
2.31 KB, patch
roc
: review+
Details | Diff | Splinter Review 
[Blocking Requested - why for this release]:

Steps to Reproduce:
   1. Open music app and start playing an offload capable music clip (mp3)
   2. Go to Settings and Turnon Bluetooth.
   3. Pair and connect to a BT headset.
   4. Once BT headset is connected playback resumes from the beginning of the clip.

Root cause:
   SeekTarget takes time in int64_t usecs whereas we pass double seconds in 2 places. Attached patch fixes this issue.
Attachment #8460143 - Flags: review?(roc)
Component: General → Video/Audio
Product: Firefox OS → Core
blocking-b2g: 2.0? → 2.0+
Whiteboard: [CR 693996] → [caf priority: p2][CR 693996]
Thanks Robert!
Submitted my first Try run https://tbpl.mozilla.org/?tree=Try&rev=3765c7f8fd08
Try run looks successful. Starred the only error.
Adding checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9caeb48e2eb8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Keywords: verifyme
QA Contact: alexandra.lucinet
I see that the affected platform here is Firefox OS. Is there something to be done on Firefox Desktop as well? Thanks in advance!
Flags: needinfo?(vasanth)
(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #6)
> Is there something to be done on Firefox Desktop as well? Thanks in advance!

I guess part of this change in MediaDecoder.cpp [1] should fix if this issue comes up in Firefox desktop.

May be we can check MediaDecoder::SeekTarget is initialized with int64_t micro seconds instead of double seconds everywhere, just to make sure same issue doesn't exist in desktop specific code.

Forwarding ni to author of SeekTarget as he might know better than me.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8460143&action=diff#a/content/media/MediaDecoder.cpp_sec2
Flags: needinfo?(vasanth) → needinfo?(cpearce)
Desktop Firefox doesn't (yet) make decoders dormant, so Desktop Firefox should not be affected this issue.
Flags: needinfo?(cpearce)
Keywords: verifyme
QA Contact: alexandra.lucinet
This will need to be covered by a new test case.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(rmitchell)
Test case added to moztrap:

https://moztrap.mozilla.org/manage/case/14378/
URL: https://moztrap.mozilla.org/manage/ca...
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(rmitchell)
Flags: in-moztrap+
(In reply to vasanth from comment #0)
> Steps to Reproduce:
>    1. Open music app and start playing an offload capable music clip (mp3)
Hi Vasanth,
Could you please tell me what audio format the offload capable music clip (mp3) is？
Flags: needinfo?(vasanth)
You need to log in before you can comment on or make changes to this bug.