1042035 - Refactor test_ipc tests to avoid code duplication

Status: REOPENED

(Testing :: Mochitest, defect)

Description

[Ahmed Kachkach [:akachkach]]

The test_ipc tests (namely: "content/media/webspeech/synth/ipc/test/test_ipc.html", "dom/devicestorage/ipc/test_ipc.html", "dom/indexedDB/ipc/test_ipc.html" and "dom/media/tests/ipc/test_ipc.html") have a lot of duplicated code, and it's currently painful to modify it (like in bug 886570).

A large portion of that code should be factored-out in a separate file included by those tests.

Comment 1

[Martijn Wargers (dead)]

Bug 1010285 talks about disabling these tests all together, if I understand correctly.

Comment 2

[Ahmed Kachkach [:akachkach]]

Yes, I just saw it and I wonder what its state is. If mochitest-e10s's coverage is equivalent to the test_ipc coverage, it's probably better to just deactivate them.

Comment 3

[Ahmed Kachkach [:akachkach]]

Probably better to wait for bug 1010285 (replacing test_ipc by the e10s tests)

Comment 4

[Ahmed Kachkach [:akachkach]]

Actually, we'll probably have to fix this since we could still have to work on the IPC tests before they're disabled (like for bug 1057558)

Comment 5

[Ahmed Kachkach [:akachkach]]

Attachment: 0001-Bug-1042035-Share-IPC-tests-code-r-Ms2ger.patch

WIP patch;

I'm having some trouble sharing some IPC code because of this:

http://dxr.mozilla.org/mozilla-central/source/dom/indexedDB/ipc/test_ipc.html#109

If I change the iframeSecondFunction by a function "dynamically" generated (with a closure to give the correct IPC "namespace") it doesn't work, because only the function's code is passed to the second iframe.

Is there a simple/clean way to do this? I'm not really familiar with IPC tests or iframes for that matter :)

Comment 6

[Ahmed Kachkach [:akachkach]]

Found a way (by passing the parameter in loadFrameScript too)

Comment 7

[Ahmed Kachkach [:akachkach]]

Attachment: 0001-Merge-ipc-tests.patch

WIP patch.

Works OK, but I have a bug on a particular test in indexedDB: is(usingChildProcess, true, "Expecting to run in child process");

(The callback doesn't seem to be called even if it's set-up properly)

Comment 8

[Ahmed Kachkach [:akachkach]]

Attachment: 0001-Bug-1042035-Share-IPC-tests-code-r-Ms2ger.patch

Old patch, here's the updated one.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.