1042040 - Define a function to generate unique ID for the XML Stanza which MUST have uniquely generated id/sid.

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[Mayank Kumar [:mayanktg]]

The XEP:0167-Jingle RTP Session and XEP:0096-SI File Transfer require uniquely generated SID (see RFC 6120 section 4.7.3).
So we would be using a common generateId() function which generates these unique IDs.

Comment 1

[Mayank Kumar [:mayanktg]]

Attachment: Add a function to generate unique id/sid.

The patch to generate unique ID/SID for XML stanzas.

Comment 2

[aleth [:aleth]]

Comment on attachment 8460199 [details] [diff] [review]
Add a function to generate unique id/sid.

Review of attachment 8460199 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp.jsm
@@ +277,5 @@
>    },
>  
> +  /* Generate unique sid for the stanza. Using id and
> +     unique sid is defined in RFC 6120 (Section 8.2.3, 4.7.3). */
> +  generateId: function() {

Please put this in the account prototype not the conversation prototype so it can be used by everything.

@@ +280,5 @@
> +     unique sid is defined in RFC 6120 (Section 8.2.3, 4.7.3). */
> +  generateId: function() {
> +    let uuid = Cc["@mozilla.org/uuid-generator;1"]
> +               .getService(Ci.nsIUUIDGenerator).generateUUID();
> +    return uuid.toString().split("-")[0].slice(1);

Why are you only using the first bit? Is there a maximum length? This doesn't seem like a good idea.

Comment 3

[Mayank Kumar [:mayanktg]]

Attachment: v2: Add a function to generate unique id/sid.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/3280f8215f89