1042068 - terminal-notifier not installed by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

I see the following error when executing bootstrap.py on OSX 10.9.4.


$ python bootstrap.py

Looks like you have Homebrew installed. We will install all required packages via Homebrew.


We are now installing all required packages via Homebrew. You will see a lot of
output as packages are built.

Homebrew 0.9.4
Error: No available formula for terminal-notifier 
Traceback (most recent call last):
  File "bootstrap.py", line 152, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 143, in main
    dasboot.bootstrap()
  File "/var/folders/wg/qmvdnqnx7cq4z27jwp3dyr3h0000gn/T/tmpqshIxr/mozboot/bootstrap.py", line 96, in bootstrap
    files = fetch_files(repo_url, repo_type)
  File "/var/folders/wg/qmvdnqnx7cq4z27jwp3dyr3h0000gn/T/tmpqshIxr/mozboot/osx.py", line 180, in install_system_packages
  File "/var/folders/wg/qmvdnqnx7cq4z27jwp3dyr3h0000gn/T/tmpqshIxr/mozboot/osx.py", line 289, in ensure_homebrew_packages
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 542, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[u'/usr/local/bin/brew', u'-v', u'install', u'terminal-notifier']' returned non-zero exit status 1

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

Following the instructions at the following link has allowed me to complete the setup. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Mac_OS_X_Prerequisites#2.1a_Install_Dependencies_via_Homebrew

It may be of note that I had to run 'brew up' in order to successfully install the prereqs.

Comment 2

[Nathan Hakkakzadeh [:Nat]]

Attachment: MozReview Request: Bug 1042068 - Added terminal-notifier to the list of packages that should be installed with homebrew.

Before, ./mach build would try to use terminal-notifier after building, but would not be able to since it isn't installed.

Review commit: https://reviewboard.mozilla.org/r/54706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54706/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8755640 [details]
MozReview Request: Bug 1042068 - Added terminal-notifier to the list of packages that should be installed with homebrew.

https://reviewboard.mozilla.org/r/54706/#review51324

Please add a blank line in your commit message after the first line and resubmit.

Comment 4

[Nathan Hakkakzadeh [:Nat]]

Comment on attachment 8755640 [details]
MozReview Request: Bug 1042068 - Added terminal-notifier to the list of packages that should be installed with homebrew.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54706/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/54706/#review51328

Comment 6

[Gregory Szorc [:gps]]

Back when this bug was filed, not all versions of OS X supported terminal-notifier. Now that we're a few years later, this should no longer be a problem. So installing terminal-notifier globally should be safe. See also bug 913276.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d174ac797c08

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d174ac797c08