1042100 - Write test for auto-adding 'default' widgets to current area placements even post-customization

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (out for now; he/him)]

From bug 1023304:

(In reply to Blair McBride [:Unfocused] from bug 1023304 comment #18)
> Though, I am worried about having no test coverage - not even manual
> coverage. Can we not test this via calling APIs via BackstagePass, to
> forcibly add a new builtin widget and then fake part of the initialization
> step again by manually calling introduceNewBuiltinWidgets() and checking
> gFuturePlacements (which is already tested)? It's not perfect, but it'd be
> far better than nothing.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Gijs, can you mark this bug as either [qa+] or [qa-] for verification.

Comment 2

[:Gijs (out for now; he/him)]

Attachment: add test for _introduceNewBuiltinWidgets,

Like this?

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 8461724 [details] [diff] [review]
add test for _introduceNewBuiltinWidgets,

Review of attachment 8461724 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/test/browser_1042100_default_placements_update.js
@@ +48,5 @@
> +
> +  normalizedWidget = CustomizableUIInternal.normalizeWidget(testWidgetOld,
> +                                                            CustomizableUI.SOURCE_BUILTIN);
> +  ok(normalizedWidget, "Widget should be normalizable");
> +  if (!normalizedWidget) {

Self-review-comment: This early return block should also delete testWidgetNew.id from gPalette.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8461724 [details] [diff] [review]
add test for _introduceNewBuiltinWidgets,

Review of attachment 8461724 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/test/browser_1042100_default_placements_update.js
@@ +9,5 @@
> +  // Customize something to make sure stuff changed:
> +  CustomizableUI.addWidgetToArea("feed-button", CustomizableUI.AREA_NAVBAR);
> +
> +  // Check what version we're on:
> +  let CustomizableUIBSPass = Cu.import("resource:///modules/CustomizableUI.jsm");

Nit: Import into dummy scope. ie:
  ... = Cu.import(..., {});

Comment 5

[:Gijs (out for now; he/him)]

w/ nit addressed:

remote:   https://hg.mozilla.org/integration/fx-team/rev/443c1f32324e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/443c1f32324e