1042124 - GMPNotifyObservers unused if MOZ_CRASHREPORTER not defined (problematic with [-Werror,-Wunused-function])

Status: RESOLVED DUPLICATE of bug 1038961

(Core :: General, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Having a .mozconfig with these options:

ac_add_options --enable-warnings-as-errors
ac_add_options --disable-crashreporter

results in:

16:55.33 In file included from /home/keeler/mozilla-central/obj-x86_64-unknown-linux-gnu/content/media/gmp/Unified_cpp_content_media_gmp0.cpp:15:
16:55.33 /home/keeler/mozilla-central/content/media/gmp/GMPParent.cpp:327:1: error: unused function 'GMPNotifyObservers' [-Werror,-Wunused-function]
16:55.33 GMPNotifyObservers(nsAString& aData)
16:55.33 ^

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: patch

Randell, would you be an appropriate reviewer for this? Thanks.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Looks like this was fixed in bug 1038961.