1042300 - In-content prefs should be nightly-only until ready

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Comment 1

[:Gijs (out for now; he/him)]

Attachment: make in-content prefs nightly-only,

Tested by toggling the ifdefs into ifndefs and rebuilding to verify the right thing shows up when opening the prefs.

Comment 2

[:Gijs (out for now; he/him)]

Marco, can you add this? This is basically pretty urgent, so I'm assuming there's no debate as to taking it this cycle. :-)

Comment 3

[:Gijs (out for now; he/him)]

Try run against *aurora* tip: https://tbpl.mozilla.org/?tree=Try&rev=12da59a77936 to check we haven't created broken-on-aurora tests since last cycle...

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1

Comment 5

[:Gijs (out for now; he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/c72ded0118f2

Comment 6

[:Gijs (out for now; he/him)]

Comment on attachment 8460539 [details] [diff] [review]
make in-content prefs nightly-only,

Approval Request Comment
[Feature/regressing bug #]: in-content prefs
[User impact if declined]: users on Aurora see our unfinished in-content prefs
[Describe test coverage new/current, TBPL]: has existing test coverage, might be broken on Aurora where we'll turn this off with this patch, hence try push in earlier comment.
[Risks and why]: see above, but that should basically be it - less risk than keeping this, though, and per discussion, turning in-content prefs off again on aurora is our best bet for the 33 cycle
[String/UUID change made/needed]: none

Comment 7

[:Gijs (out for now; he/him)]

(In reply to :Gijs Kruitbosch (Gone July 26 - August 3) from comment #3)
> Try run against *aurora* tip:
> https://tbpl.mozilla.org/?tree=Try&rev=12da59a77936 to check we haven't
> created broken-on-aurora tests since last cycle...

1993 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js | Test timed out - Test timed out

Across the board. :-(


All of e10s is extremely sad, I think that's just because it's not enabled on Aurora? And then there's some random stuff, but with just linux and os x coverage so far, it seems not too terrible.

Comment 8

[:Gijs (out for now; he/him)]

Attachment: test fix: shouldn't assume in-content and instantApply prefs are enabled,

Comment 9

[:Gijs (out for now; he/him)]

Renewed try push because Windows was timing out and while I think it's due to the test that's fixed by this patch, I would prefer to be sure before uplift:

remote:   https://tbpl.mozilla.org/?tree=Try&rev=36286bee164b

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c72ded0118f2

Comment 11

[:Gijs (out for now; he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/854bac92e5e3

Comment 12

[:Gijs (out for now; he/him)]

(In reply to :Gijs Kruitbosch (Gone July 26 - August 3) from comment #9)
> Renewed try push because Windows was timing out and while I think it's due
> to the test that's fixed by this patch, I would prefer to be sure before
> uplift:
> 
> remote:   https://tbpl.mozilla.org/?tree=Try&rev=36286bee164b

This is green apart from e10s sadness, so I think we're good to uplift both of these. Sylvestre, mind if I do that ASAP?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/854bac92e5e3

Comment 14

[Marco Mucci [:MarcoM]]

Hi Florin, can a QA contact be assigned for verification of this bug.

Comment 15

[:Gijs (out for now; he/him)]

got approval from lsblakk over IRC in #planning:

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/4d2100935ac9
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/e91fe41e2d51

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8460539 [details] [diff] [review]
make in-content prefs nightly-only,

Has been already merged.

Comment 17

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verified on Win 7 x64, Ubuntu 12.10 x86, Mac OS X 10.9.4:
- latest Firefox 33 Aurora (BuildID: 20140724004002) - old Preferences window opens
- latest Firefox 34 Nightly (BuildID: 20140724030201) - new in-content Preferences tab opens