Closed Bug 1042300 Opened 5 years ago Closed 5 years ago

In-content prefs should be nightly-only until ready

Categories

(Firefox :: Preferences, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox33 --- verified disabled
firefox34 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(2 files)

No description provided.
Tested by toggling the ifdefs into ifndefs and rebuilding to verify the right thing shows up when opening the prefs.
Attachment #8460539 - Flags: review?(MattN+bmo)
Marco, can you add this? This is basically pretty urgent, so I'm assuming there's no debate as to taking it this cycle. :-)
Status: NEW → ASSIGNED
Iteration: --- → 34.1
Points: --- → 1
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Try run against *aurora* tip: https://tbpl.mozilla.org/?tree=Try&rev=12da59a77936 to check we haven't created broken-on-aurora tests since last cycle...
Attachment #8460539 - Flags: review?(MattN+bmo) → review+
Added to Iteration 34.1
QA Whiteboard: [qa?]
Flags: needinfo?(mmucci)
QA Whiteboard: [qa?] → [qa+]
Whiteboard: [fixed-in-fx-team]
Comment on attachment 8460539 [details] [diff] [review]
make in-content prefs nightly-only,

Approval Request Comment
[Feature/regressing bug #]: in-content prefs
[User impact if declined]: users on Aurora see our unfinished in-content prefs
[Describe test coverage new/current, TBPL]: has existing test coverage, might be broken on Aurora where we'll turn this off with this patch, hence try push in earlier comment.
[Risks and why]: see above, but that should basically be it - less risk than keeping this, though, and per discussion, turning in-content prefs off again on aurora is our best bet for the 33 cycle
[String/UUID change made/needed]: none
Attachment #8460539 - Flags: approval-mozilla-aurora?
(In reply to :Gijs Kruitbosch (Gone July 26 - August 3) from comment #3)
> Try run against *aurora* tip:
> https://tbpl.mozilla.org/?tree=Try&rev=12da59a77936 to check we haven't
> created broken-on-aurora tests since last cycle...

1993 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js | Test timed out - Test timed out

Across the board. :-(


All of e10s is extremely sad, I think that's just because it's not enabled on Aurora? And then there's some random stuff, but with just linux and os x coverage so far, it seems not too terrible.
Keywords: leave-open
Depends on: 1020245
Renewed try push because Windows was timing out and while I think it's due to the test that's fixed by this patch, I would prefer to be sure before uplift:

remote:   https://tbpl.mozilla.org/?tree=Try&rev=36286bee164b
remote:   https://hg.mozilla.org/integration/fx-team/rev/854bac92e5e3
Keywords: leave-open
Whiteboard: [fixed-in-fx-team]
(In reply to :Gijs Kruitbosch (Gone July 26 - August 3) from comment #9)
> Renewed try push because Windows was timing out and while I think it's due
> to the test that's fixed by this patch, I would prefer to be sure before
> uplift:
> 
> remote:   https://tbpl.mozilla.org/?tree=Try&rev=36286bee164b

This is green apart from e10s sadness, so I think we're good to uplift both of these. Sylvestre, mind if I do that ASAP?
Flags: needinfo?(sledru)
https://hg.mozilla.org/mozilla-central/rev/854bac92e5e3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Hi Florin, can a QA contact be assigned for verification of this bug.
Flags: needinfo?(florin.mezei)
got approval from lsblakk over IRC in #planning:

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/4d2100935ac9
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/e91fe41e2d51
Flags: needinfo?(sledru)
Flags: needinfo?(florin.mezei)
QA Contact: camelia.badau
Comment on attachment 8460539 [details] [diff] [review]
make in-content prefs nightly-only,

Has been already merged.
Attachment #8460539 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on Win 7 x64, Ubuntu 12.10 x86, Mac OS X 10.9.4:
- latest Firefox 33 Aurora (BuildID: 20140724004002) - old Preferences window opens
- latest Firefox 34 Nightly (BuildID: 20140724030201) - new in-content Preferences tab opens
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.