1042308 - Forcibly return MediaBuffer to OMXCodec during OMXCodec shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1035755 +++

OMXCodec has a very strong restriction how MediaBuffer is handled during OMXCodec Shutdown. If there is even one MediaBuffer is held in gecko, OMXCodec crashes an current application process. It is necessary to prevent this situation on production build.

Until now, we fixed the problem by fixing all bugs reported to bugzilla. But this has a limitation. One solution is [3] in Bug 1009420 Comment 14. But it can be applied only to MediaCodec, it is still under investigation and it is not clear yet if it is possible solution.

One possible workaround to this problem is that OmxDecoder forcibly return MediaBuffer to OMXCodec if OmxDecoder detects the problematic situation during OMXCodec shutdown. It has a regression risk, but it might be better than the crash in production.

Comment 1

[Sotaro Ikeda [:sotaro]]

It is very difficult to prevent problem without such workaround. When one object is still holding TextureClient, a MediaBuffer of the TextureClient is not returned to OMXCodec. Sometimes, it is very difficult to analyze which object is holding a reference pointer to the TextureClient. We often can not get a actual STR of the crash.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Return All MediaBuffers to OMXCodec during OMXCodec shutdown

Comment 3

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=508420ecf63a

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8461014 [details] [diff] [review]
patch - Return All MediaBuffers to OMXCodec during OMXCodec shutdown

Review of attachment 8461014 [details] [diff] [review]:
-----------------------------------------------------------------

I am not very familiar with OMXDecoder but it looks good to me (with my limited knowledge of this stuff).

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Return All MediaBuffers to OMXCodec during OMXCodec shutdown

Add race condition fix. Carry "r=cajbir,nical".

Comment 6

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef9dd45733b6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef9dd45733b6