Closed Bug 1042348 Opened 8 years ago Closed 8 years ago

crash in libsystem_kernel.dylib@0x15866 (mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunchInternal)

Categories

(Core :: WebRTC, defect)

All
macOS
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla34
Tracking Status
firefox34 --- verified

People

(Reporter: drno, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

(Keywords: crash, Whiteboard: fixed by bug 1041525)

Crash Data

This bug was filed from the Socorro interface and is 
report bp-c3fb9e06-34a6-4260-9e61-699c02140722.
=============================================================
This was after starting todays Nightly (34.0a1 (2014-07-22)), wait for the Plugin to become enabled and then try to place an H264 only call via webrtc-landing/pc_test.html
I saw this with today's Nightly (7-22) but only on OSX, the other two platforms worked for me.  Also only on the build from nightly.mozilla.org and not when I build locally without crashreporter.
Georg -- I know you're fixing crash reporter now.  Can you look at the crash on this bug and tell me if this looks like an issue you're already fixing?
Blocks: OpenH264
Flags: needinfo?(georg.fritzsche)
Those look like hang reports (EXC_SOFTWARE / SIGABRT).
If they are, then they are dupes of bug 1041525 - Ethan?
Flags: needinfo?(georg.fritzsche) → needinfo?(ethanhugg)
Hm, actually they are 34.0a1 crashes, so it can't be bug 1041525 exactly as that one is worked around.
Due to the similar stacks i'm suspecting this has a common cause with bug 1041525.
Here's one from my Mac:
https://crash-stats.mozilla.com/report/index/b2b60a27-194e-43de-af0b-119732140722

So it's probably the same cause.  They happen at the same time while setting up the 264 call.  Monday's build just hung with the wait icon indefinitely, Tuesday's build crashes to desktop.  Both were 100% repeatable for me.
Flags: needinfo?(ethanhugg)
(In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> Hm, actually they are 34.0a1 crashes, so it can't be bug 1041525 exactly as that one is worked around.
> Due to the similar stacks i'm suspecting this has a common cause with bug 1041525.

Georg -- Since this looks like it has a common cause with bug 1041525, I think it makes sense to assign this to you.
Assignee: nobody → georg.fritzsche
This should be fixed by bug 1041525.

We're crashing on the std::vector<std::string>::push_back() line here:
http://hg.mozilla.org/mozilla-central/annotate/63f44b4968c2/ipc/glue/GeckoChildProcessHost.cpp#l668

Bug 1041525 disabled the crashreporter initialization, so we end up requesting an - uninitialized - pipe identifier (char*):
http://hg.mozilla.org/mozilla-central/annotate/63f44b4968c2/toolkit/crashreporter/nsExceptionHandler.cpp#l2666
http://hg.mozilla.org/mozilla-central/annotate/63f44b4968c2/toolkit/crashreporter/nsExceptionHandler.cpp#l279
... and end up constructing a std::string from it.
Depends on: 1041525
Whiteboard: [openh264-uplift]
Can you verify this is now fixed on inbound?  (or if you believe it is, close and if we're wrong it will be reopened or a new bug filed.)  Thanks.
Flags: needinfo?(georg.fritzsche)
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(georg.fritzsche)
Resolution: --- → FIXED
Whiteboard: [openh264-uplift] → [openh264-uplift] fixed by bug 1041525
Duplicate of this bug: 1042215
Target Milestone: --- → mozilla34
Whiteboard: [openh264-uplift] fixed by bug 1041525 → fixed by bug 1041525
Nils, is this something you could verify for us? If not maybe Alexandra can take it on. Thanks!
Flags: needinfo?(drno)
QA Contact: drno
In all my manual tests I have not encountered a crash again. So I think this seems to be fixed.
Flags: needinfo?(drno)
Marking this bug as verified based on comment 13.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.