1042381 - User prompted to pay with an older SIM account even after newly logging in

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: verbose logging for sim exchange.txt

Connectivity: wifi/data enabled
SIM used: 1) Movistar 2) Deustche Telekom poland
Gaia/device: 1.3/hamachi

steps to reproduce:
1. SIM1 (Movistar) is in the phone and you have done at least one purchase (or MT auth with that SIM)
2. Switch to SIM 2 (DT poland)
3. Log out of Marketplace-stage
4. Search for :paid
5. Start the purchase of an app
6. Sign in using persona
7. Enter PIN
8. Notice the confirm screen


expected behavior:
User is prompted to pay for the app using carrier billing on DT


actual behavior:
User is prompted to pay for the app using carrier billing on movistar.

Comment 1

[krupa raj[:krupa]]

Attachment: region correctly set to Poland on Marketplace

Comment 2

[krupa raj[:krupa]]

Attachment: details page shows the right currency

Comment 3

[krupa raj[:krupa]]

Attachment: Bango confirm screen incorrecty shows Movistar

Comment 4

[Kumar McMillan [:kumar]]

I'm removing Keir from the cc for now as this is not a Bango bug.

This appears to be either a Webpay or platform issue:

07-22 18:52:32.529 E/GeckoConsole(  135): Content JS LOG at https://marketplace-cdn.allizom.org/mozpay/media/js/pay-min.js?build=28e7d32-53cecb4c:5 in w: [pay] Probably logged in, Persona never called back
07-22 18:52:32.529 E/GeckoConsole(  135): Content JS LOG at https://marketplace-cdn.allizom.org/mozpay/media/js/pay-min.js?build=28e7d32-53cecb4c:5 in n: [bango] sim did not change

Comment 5

[Kumar McMillan [:kumar]]

bumping up because the sim change was not detected and that could cause other problems

Comment 6

[Kumar McMillan [:kumar]]

Fixed: https://github.com/mozilla/spartacus/pull/108

Our logout code was clearing all local storage which erased memory of the last user and last SIM. This clear was completely unnecessary as far as I could tell.

Comment 7

[Stuart Colville [:muffinresearch]]

(In reply to Kumar McMillan [:kumar] (needinfo for quickness) from comment #6)
> Fixed: https://github.com/mozilla/spartacus/pull/108
> 
> Our logout code was clearing all local storage which erased memory of the
> last user and last SIM. This clear was completely unnecessary as far as I
> could tell.

The STR are from staging due to this happening in the webpay JS. Thinking this fix should also happen in webpay or the STR will continue to be reproducible.

Comment 8

[Kumar McMillan [:kumar]]

Oh, hah, I somehow missed that this was on Webpay but yeah same fix should apply

Comment 9

[Kumar McMillan [:kumar]]

ported to Webpay: https://github.com/mozilla/webpay/pull/539