1042398 - Xray waivers miss custom iterators

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This is a longstanding bug, but the compat impact is a regression from bug 856067. We should take this patch on 33.

Comment 1

[Bobby Holley (:bholley)]

[Tracking Requested - why for this release]: See comment 0. The patch should land on m-i within a date and is very safe.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #1)
> land on m-i within a date

*within a day.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Add a WaiveXrayWrapper override for ::iterate. v1

I thought we had overrides for all the proxy traps that returned non-primitive
values, but it looks like we missed one.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Tests. v2 r=bholley

Comment 5

[Bobby Holley (:bholley)]

For more context - the issue here is that our Xray waivers (which are used from chrome and addon code) miss a certain corner case (custom iterators). This has always been the case, but wasn't noticeable before bug 856067. Now that we deny access to non-waived objects, the lack of a waiver here becomes a problem.

The potential for addon-compat fallout is low, but the fix is really safe and we just need it on aurora.

https://tbpl.mozilla.org/?tree=Try&rev=e69c167c6fd6

Comment 6

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8460642 [details] [diff] [review]
Add a WaiveXrayWrapper override for ::iterate. v1

Review of attachment 8460642 [details] [diff] [review]:
-----------------------------------------------------------------

Uhh... I was not even aware of that trap :(

Comment 7

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/79d2db9a2a2c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/88860bed8c96

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/deff412c2d45 and https://hg.mozilla.org/integration/mozilla-inbound/rev/66cb4d556959 for build bustage:

https://tbpl.mozilla.org/php/getParsedLog.php?id=44456475&tree=Mozilla-Inbound

Comment 9

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=b7337de650b6

Comment 10

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/25608b44a408
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6878d55c8dda

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25608b44a408
https://hg.mozilla.org/mozilla-central/rev/6878d55c8dda

Comment 12

[Bobby Holley (:bholley)]

Comment on attachment 8460642 [details] [diff] [review]
Add a WaiveXrayWrapper override for ::iterate. v1

Approval Request Comment
[Feature/regressing bug #]: See comment 5.
[User impact if declined]: Small potential for addon breakage.
[Describe test coverage new/current, TBPL]: Automated test included, and in general we have lots of test coverage for this stuff.
[Risks and why]: Extremely low risk.
[String/UUID change made/needed]: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8b4670845e03
https://hg.mozilla.org/releases/mozilla-aurora/rev/822b25aca158

Comment 14

[Matt Wobensmith [:mwobensmith][:matt:]]

Tests look good in Fx33/Fx34. They also look good in Fx31/Fx32, so I can't say if I've truly verified a change, but they pass nonetheless.