1042501 - min-width on main UI puts dropdown scrollbars out of reach

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Mike Hommey [:glandium]]

My browser window is 960px large because it is exactly half the horizontal monitor resolution. Add to that the scrollbar and I probably have somewhere between 950 and 960 pixels available.

Now, with treeherder opened, when I open the repos or filter dropdowns, they end up being useless to me because their scrollbar, which is necessary to do most things with them, are out of reach, and while there is an horizontal scrollbar, it doesn't apply to the dropdowns.

Looking at the CSS, I see a min-width: 970px on at least body, .th-content, .navbar, .th-global-navbar, and .th-context-navbar...

Comment 1

[William Lachance (:wlach)]

My proposed patch to bug 1042599 fixes this.

Comment 2

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #1)
> My proposed patch to bug 1042599 fixes this.

Actually wait, no it doesn't. Though you could probably apply similar techniques used there here...

Comment 3

[William Lachance (:wlach)]

I'll take this one.

Comment 4

[William Lachance (:wlach)]

Attachment: Remove use of min-width

So I did some investigation and I think we can just remove the use of min-width. It doesn't really do much other than cause this problem at this point. :) In general, treeherder doesn't work well with less than 800 or so horizontal pixels

Comment 6

[William Lachance (:wlach)]

Hey Ed, it looks like Glandium is out right now, do you want to take a look and resolve if appropriate?

Comment 7

[Ed Morley [:emorley]]

Looks good now - thank you :-)

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4b0518ed59d61fad3c3d7a2139dfd73cc911f973
Bug 1042501 - Remove all use of min-width in treeherder's CSS

It doesn't really help anything and causes (at least) the repo panel
to not scroll properly if the screen size is below a certain threshold.

https://github.com/mozilla/treeherder/commit/d0d0b2b2bf0e158ce2ecc124b2e8706c06fa0433
Merge pull request #139 from wlach/1042501

Bug 1042501 - Remove all use of min-width in treeherder's CSS