1042502 - No need to removeObserver in Snippets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: snippet-fix v0.1

In fact, trying to remove the observer will throw an error:
JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]" {file: "/components/Snippets.js" line: 389}]

We use component category now, so we never need to addObserver anymore.

Comment 1

[:Margaret Leibovic]

Comment on attachment 8460738 [details] [diff] [review]
snippet-fix v0.1

Review of attachment 8460738 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the follow-up.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/73b61749c377

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/73b61749c377

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8460738 [details] [diff] [review]
snippet-fix v0.1

Approval Request Comment
[Feature/regressing bug #]:bug 964511
[User impact if declined]:No snippets
[Describe test coverage new/current, TBPL]: Works fine in Nightly
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7fc1cdf6978e

Comment 7

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed using the steps from Bug 1043851. Snippets are displayed on both builds, Nightly and Aurora.
Builds:
Aurora 33.0a2 (2014-07-29)
Nightly 34.0a1 (2014-07-29)

Device: Asus Transformer Pad TF300T (Android 4.2.1)