Closed Bug 1042504 Opened 5 years ago Closed 5 years ago

update speex resampler to speexdsp 305e54ea

Categories

(Core :: Web Audio, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
blocking-b2g 2.0+
Tracking Status
firefox32 --- wontfix
firefox33 --- wontfix
firefox34 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(4 files)

Development of the speex resampler is happening more in speexdsp than opus-tools now.

Some upstream work in speexdsp includes neon support for the direct resampler, and I'm expecting some other changes soon that we want.  I'll file another bug about enabling the neon support.  This one is just about switching to speexdsp and updating existing files.
Blocks: 1042508
This is the speexdsp revision most similar to what is currently in Gecko.
Attachment #8460745 - Flags: review?(paul)
Upstream SATURATE32PSHR changes conflict with Gecko's SSE runtime
detection patch.  That patch is updated to reduce deviation from
upstream.
Attachment #8460746 - Flags: review?(paul)
Attachment #8460744 - Flags: review?(paul) → review+
Comment on attachment 8460745 [details] [diff] [review]
part 2: switch speex resampler to speexdsp bbe7e099

Review of attachment 8460745 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libspeex_resampler/README_MOZILLA
@@ +1,1 @@
>  This source is from the Speex library (http://git.xiph.org/speex.git/), from

Maybe we want to update this URL to point to http://git.xiph.org/?p=speexdsp.git ?
Attachment #8460745 - Flags: review?(paul) → review+
Attachment #8460746 - Flags: review?(paul) → review+
Attachment #8460747 - Flags: review?(paul) → review+
(In reply to Paul Adenot (:padenot) from comment #5)
> Maybe we want to update this URL to point to
> http://git.xiph.org/?p=speexdsp.git ?

Yes, I've made that change now, thanks.
Flags: in-testsuite-
QA Whiteboard: [qa-]
[Blocking Requested - why for this release]: Blocks bug 1042508. Per bug 1042508 comment 19, uplifting this is the least-risky path to getting it uplifted. Bug 1042508 commment 29 contains a Try push of the entire patch stack on top of b2g32.
blocking-b2g: --- → 2.0?
blocking for a clean/less risky uplift of 1042508
blocking-b2g: 2.0? → 2.0+
You need to log in before you can comment on or make changes to this bug.