Closed Bug 1042513 Opened 5 years ago Closed 5 years ago
Clearing timer in Firefly shutdown is racy and not needed
Attachment #8460743 - Flags: review?(blassey.bugs)
I should note that the exception I get when attempting to shutdown means the video session does not shutdown. I have to keep tapping the button until I will the race. With the patch, it's not a problem.
Attachment #8460743 - Flags: review?(blassey.bugs) → review+
tracking-fennec: --- → 33+
Comment on attachment 8460743 [details] [diff] [review] firefly-fix v0.1 Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: Video casting session won't shutdown [Describe test coverage new/current, TBPL]: Working fine in Nightly [Risks and why]: low [String/UUID change made/needed]: none
Attachment #8460743 - Flags: approval-mozilla-aurora?
landed in m-c on 7/23: http://hg.mozilla.org/mozilla-central/rev/ac723928f295
Attachment #8460743 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.