Closed
Bug 1042530
Opened 11 years ago
Closed 11 years ago
Update wait in test_settings_root
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: viorela, Assigned: viorela)
Details
Attachments
(1 file)
Due to changes in https://github.com/mozilla-b2g/gaia/commit/c9105b7e8e78495786c648197d92dc9b87c489ba, the wifi status is displayed as soon as we launch settings app.
As in the test we are waiting for the wifi status to be displayed, it will fail because the bluetooth status is displayed later.
We should update the test by changing the wait we currently have.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8460769 -
Flags: review?(zcampbell)
Attachment #8460769 -
Flags: review?(florin.strugariu)
Updated•11 years ago
|
Attachment #8460769 -
Flags: review?(zcampbell)
Attachment #8460769 -
Flags: review?(florin.strugariu)
Attachment #8460769 -
Flags: review+
![]() |
||
Comment 2•11 years ago
|
||
Comment on attachment 8460769 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/22060
r- I looked at the timing of the launch method and I could not see data-ready=true before this element was initialised so I don't think this change changes anything.
Attachment #8460769 -
Flags: review-
Assignee | ||
Comment 3•11 years ago
|
||
I added a check after https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py#L45 and data-ready=true was present.
When we launch Settings app, the bluetooth state is the last element displayed, that's why we should wait for it to be displayed, before checking other's elements status.
The pull with the changes was merged in: https://github.com/mozilla-b2g/gaia/commit/8354f27f0a089b9c4cc6eb14b35360ba778bb197 and the test runs as expected.
I will close this bug.
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•