104258 - Dlg for setting to default mail should not appear when I'm composing a msg

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P3)

Description

[lchiang]

Dlg for setting to default mail should not appear when I'm composing a msg

Win32 2001-10-11-10-094 branch build
One profile only
Preference set to launch both browser and mail at startup of program

1.  Make sure you have the preference set to use MAPI Send in Netscape 6.  Exit 
Netscape 6.  
2.  Start Netscape 6
3.  Browser window appears.  Mail window appears.  Login to mail (IMAP)
4.  Edit | Preferences
5.  Disable the preference to use MAPI Send
6.  Click OK
7.  Back at the 3pane mail window, select a message and reply to it
8.  Compose window appears, but you get a dialog:

"Do you want to use Netscape 6 as the default mail application."

This is a strange time to put up this dialog.

I don't believe this is related to 103908 since I've never checked the box to 
not show me this dialog again.

Comment 1

[Scott MacGregor]

that's strange lisa. You should have seen the mapi dialog when the mail window
appears. But you didn't see it until you brought up a compose window?

Comment 2

[(not reading, please use [e-mail] instead)]

you'll get the dialog when launching the 3 pane, compose or address book,
because we piggy back off of verifyAccounts().

is this check only supposed to happen when using the 3 pane?

Comment 3

[Tiantian Kong]

Srilatha will work on this.

Comment 4

[(not reading, please use [e-mail] instead)]

using verifyAccounts() makes it so if we are going to put up the mapi dialog, we
do so on the first "mailnews" window, which includes the 3 pane, compose and
addressbook.

but reading lisa's original comment, this sounds like a problem with how we
figure out if we want to show the dialog or not.

Comment 5

[Srilatha Moturi]

Seth is right. This is the problem with how how we figure out if we want to show 
the dialog or not.
I have a fix for this. I will have to test it little bit and then I'll post a 
patch.

Comment 6

[Srilatha Moturi]

Attachment: patch v1

Comment 7

[Srilatha Moturi]

ccing ssu for r=
mscott can you do the sr=

Comment 8

[Jaime Rodriguez, Jr.]

We might want to take this one, if this happens more than once in a session.

Comment 9

[Sean Su]

Comment on attachment 53313 [details] [diff] [review]
patch v1

r=ssu

Comment 10

[lchiang]

This happens only once per session.  The next time, I'll see this dlg at the
"normal time" which is when I start mail (3pane) comes up.

Comment 11

[Scott MacGregor]

Comment on attachment 53313 [details] [diff] [review]
patch v1

sr=mscott

Comment 12

[Scott MacGregor]

lisa once per session means every time you start the app right? And not once per
profile? If the former, then it sounds severe due to the frequent visibility. 

Comment 13

[lchiang]

The resulting behavior is not severe.

When this "ask me" dialog comes up in the Compose window (following my original
steps), I choose NO, but I leave the "don't ask me again" checkbox unchecked.

I see this dialog again each subsequent time I start Netscape 6.  That is
acceptable since I never checked the "don't ask me again" checkbox.

This bug report should be for the logic that within the same session, if I've
just disabled MAPI, the application should not turn around and ask me again to
make us the default application.

Comment 14

[jglick]

What Lisa did was launch Mail, turn the MAPI pref Off, launch a compose window, 
and then was prompted (default mail client). If mail is already running, and the 
user turns the pref off, we shouldn't prompt them when they launch a new mail 
window (during the same session).

When they quit Mail and then relaunch Mail, then bug them. :-)

Comment 15

[Jaime Rodriguez, Jr.]

If this is accpetable, then let's go ahead and PDT- for 094, right?

Comment 16

[Srilatha Moturi]

With the patch, in the test case mentioned by Lisa, we bring up the dialog
When the user  quits The whole application and then relaunch Mail.
Jennifer is that ok.

Comment 17

[jglick]

If Lisa is fine with that, fine with me. :-)

Comment 18

[Jaime Rodriguez, Jr.]

PDT-, its too late to be making dialogue changes at this time.

Comment 19

[Tiantian Kong]

We are not added new dialog. We are just changing the time when the dialog will
be displayed.

Comment 20

[Jaime Rodriguez, Jr.]

Still PDT-.

Comment 21

[Srilatha Moturi]

Attachment: updated patch

updated the patch against the head

Comment 22

[Srilatha Moturi]

Attachment: updated patch

updated the patch against the head

Comment 23

[Scott MacGregor]

Comment on attachment 64345 [details] [diff] [review]
updated patch

sr=mscott

Comment 24

[Sean Su]

Comment on attachment 64345 [details] [diff] [review]
updated patch

r=ssu

Comment 25

[Srilatha Moturi]

Fix checked in.

Comment 26

[Jaime Rodriguez, Jr.]

Removign PDT grafitti.

Comment 27

[Trix Supremo]

verified on trunk 2002042512