1042689 - crash in java.lang.RuntimeException: Camera is already stopped! at org.webrtc.videoengine.VideoCaptureAndroid.stopCapture(VideoCaptureAndroid.java)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Flaviu Cos]

This bug was filed from the Socorro interface and is 
report bp-dbf6ba96-0551-4d03-9c7e-da90f2140723.
=============================================================

Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 34.0a1 (2014-07-23);

Steps to reproduce:
1. Go to http://mozilla.github.com/webrtc-landing/gum_test.html and select Video;
2. Accept permissions;
3. Quit Firefox by selecting 'Quit' from the options menu.

Expected result:
Firefox successfully quits.

Actual result:
Firefox crashes.

Stack trace:
java.lang.RuntimeException: Camera is already stopped!
	at org.webrtc.videoengine.VideoCaptureAndroid.stopCapture(VideoCaptureAndroid.java:235)
	at dalvik.system.NativeStart.run(Native Method)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

>3. Quit Firefox by selecting 'Quit' from the options menu.

Clarified on IRC this requires "clear data on quit" or something similar to be enabled.

Comment 2

[Aaron Train [:aaronmt]]

Gingerbread has a quit menu item by default for reasons I can't remember why

Comment 3

[Flaviu Cos]

Last good build: 2014-05-30;
First bad build: 2014-05-31;

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e6f113c83095&tochange=323156681cef

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Almost certainly caused by the 987979 update.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. fix-double-stop

When pressing quit, the Android code gets the onPause notification before the native code has had a chance to stop the camera. So it'll pause, disable the camera, after which the native code tries to stop the already stopped capture.

Deal with this correctly. Coincidentally also deal with getting a stopCapture exactly when we're being backgrounded, which looks pretty much the same.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68551387765a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/68551387765a