Closed Bug 1042705 Opened 9 years ago Closed 9 years ago

Add the 'repo' param to the URL, even for the default repo

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: KWierso)

Details

Attachments

(1 file)

Add repo=mozilla-central by default
49 bytes, text/x-github-pull-request
camd
: review+
Details | Review 
When you visit https://treeherder.mozilla.org/ui/#/jobs the view default to mozilla-central (which is perfect), however the URL doesn't include "repo=mozilla-central". 

I know this matches TBPL behaviour, but it does make it harder to quickly grok from the location bar which repo you are viewing, as well as mean it takes longer to tweak the URL when adding params. In addition, if we ever change the default repo, having the repo always be set would mean existing links would continue to work.
I'd like to take this one on.

My understanding is that I'd need to add something to this file: https://github.com/mozilla/treeherder-ui/blob/a7aecdad13fb8203769b133c55eb884bf2c9f427/webapp/app/js/controllers/jobs.js#L25
To replace the document location with a URL including the repo parameter.


Do you know if that can be done with the $routeParams or $location, or should I just use location.replace()?

As part of this, I'll fix the comment above that code block to indicate that mozilla-central is the default, not inbound like it used to be.
Assignee: nobody → kwierso
Flags: needinfo?(emorley)
(Answered on IRC)
Flags: needinfo?(emorley)
Attachment #8485215 - Flags: review?(cdawson) → review+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/736c067e24506f8c4d6351b4493dab21b6b4cfc2
Bug 1042705 - Add the default repo parameter to the URL if no repo is specified

https://github.com/mozilla/treeherder/commit/251842c0b118c9df094baf20f600c9a84e4f3f37
Merge pull request #153 from KWierso/1042705

Bug 1042705 - Add the default repo parameter to the URL if no repo is specified
You need to log in before you can comment on or make changes to this bug.