Closed
Bug 1042840
Opened 11 years ago
Closed 11 years ago
Drop support for evalInWindow
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
13.73 KB,
patch
|
gkrizsanits
:
review+
|
Details | Diff | Splinter Review |
Now that eval() resolves on Xrayed globals, this is unnecessary. The only functional difference between the two is that evalInWindow implicitly clones its return value, and we've decided in bug 1042824 that we want to move away from implicit cloning.
Thankfully, evalInWindow doesn't appear to be used on addons MXR, and I don't think we ever had docs for it either.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8461697 -
Flags: review?(gkrizsanits)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8461697 -
Flags: review?(gkrizsanits) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
|
||
Updated•11 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•