Closed Bug 1042840 Opened 5 years ago Closed 5 years ago

Drop support for evalInWindow

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Now that eval() resolves on Xrayed globals, this is unnecessary. The only functional difference between the two is that evalInWindow implicitly clones its return value, and we've decided in bug 1042824 that we want to move away from implicit cloning.

Thankfully, evalInWindow doesn't appear to be used on addons MXR, and I don't think we ever had docs for it either.
Attachment #8461697 - Flags: review?(gkrizsanits)
Attachment #8461697 - Flags: review?(gkrizsanits) → review+
https://hg.mozilla.org/mozilla-central/rev/655c65e5ba57
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.