Closed Bug 1043091 Opened 7 years ago Closed 7 years ago

Disable non-unified builds on b2g32

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

(Whiteboard: [capacity])

Attachments

(1 file, 1 obsolete file)

Like the other release branches, all regular builds are non-unified anyway. Looks like some tweaking to what landed in bug 967337 is all that's needed. Didn't we recently land some fancy "run this only on trunk" code, catlee? :)
Attached patch patch (obsolete) — Splinter Review
This shameless steals the logic added by bug 1002800 and hopefully adapts it correctly to non-unified builds and static analysis.

My only concern (other than the whole "is the loop logic correct?" part) is that from the code, I'd expect Static Analysis builds to currently be running on b2g32 as well (given their lack of blacklisting), but they aren't AFAICT.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8463731 - Flags: review?(catlee)
Attachment #8463731 - Flags: review?(catlee) → review+
Comment on attachment 8463731 [details] [diff] [review]
patch

Backed out for releng-ci failures.
http://hg.mozilla.org/build/buildbot-configs/rev/e4b3e4ccb7dd

INFO  -   File "/run/shm/buildbot/bm75-try1-universal-n1xNOg/config.py", line 2544, in <module>
INFO  -     for pc in BRANCHES[branch]['platforms'].values():
INFO  - TypeError: unhashable type: 'dict'
Attachment #8463731 - Flags: checked-in+ → checked-in-
Attached patch patch v2Splinter Review
Per IRC discussion
Attachment #8463731 - Attachment is obsolete: true
Attachment #8464161 - Flags: review?(catlee)
Attachment #8464161 - Flags: review?(catlee) → review+
And now to fix the logic fail on my part that caused my patch to do exactly the opposite of what I was shooting for....
https://hg.mozilla.org/build/buildbot-configs/rev/78ea14704049
something(s) here went to production today
Everything appears to be working correctly since the follow-up went into production.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1047670
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.