1043091 - Disable non-unified builds on b2g32

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Like the other release branches, all regular builds are non-unified anyway. Looks like some tweaking to what landed in bug 967337 is all that's needed. Didn't we recently land some fancy "run this only on trunk" code, catlee? :)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

This shameless steals the logic added by bug 1002800 and hopefully adapts it correctly to non-unified builds and static analysis.

My only concern (other than the whole "is the loop logic correct?" part) is that from the code, I'd expect Static Analysis builds to currently be running on b2g32 as well (given their lack of blacklisting), but they aren't AFAICT.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8463731 [details] [diff] [review]
patch

https://hg.mozilla.org/build/buildbot-configs/rev/1846b230190e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8463731 [details] [diff] [review]
patch

Backed out for releng-ci failures.
http://hg.mozilla.org/build/buildbot-configs/rev/e4b3e4ccb7dd

INFO  -   File "/run/shm/buildbot/bm75-try1-universal-n1xNOg/config.py", line 2544, in <module>
INFO  -     for pc in BRANCHES[branch]['platforms'].values():
INFO  - TypeError: unhashable type: 'dict'

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch v2

Per IRC discussion

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8464161 [details] [diff] [review]
patch v2

https://hg.mozilla.org/build/buildbot-configs/rev/241969c5dfe8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

And now to fix the logic fail on my part that caused my patch to do exactly the opposite of what I was shooting for....
https://hg.mozilla.org/build/buildbot-configs/rev/78ea14704049

Comment 7

[Justin Wood (:Callek)]

something(s) here went to production today

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Everything appears to be working correctly since the follow-up went into production.