Closed
Bug 1043108
Opened 9 years ago
Closed 9 years ago
Remove arch:IA32 from non-x86 builds
Categories
(Firefox Build System :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(3 files)
1.61 KB,
patch
|
away
:
review+
|
Details | Diff | Splinter Review |
1.18 KB,
patch
|
away
:
review+
KaiE
:
superreview+
|
Details | Diff | Splinter Review |
2.04 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #37) > -arch:IA32 is not valid when doing x64 builds, but configure will now > unconditionally add it. This creates a lot of spam during the build: > > cl : Command line warning D9002 : ignoring unknown option '-arch:IA32' > > We should only add this option when doing 32-bit builds.
How can I detect architecture in the NSS/NSPR builds? I tried testing CPU_ARCH, but it seems that's not the right thing to use. On my win64 build, CPU_ARCH is x386 in NSS and x86 in NSPR.
Flags: needinfo?(wtc)
Comment 2•9 years ago
|
||
David: after inspecting the NSPR configure.in script, I think this is the most convenient place to add the -arch:IA32 flag to x86 builds. An alternative solution is to duplicate the case statement where we currently add the -arch:IA32 flag: case "$target_cpu" in i*86) if test "$MSC_VER" -ge "1700" -a -z "$USE_64"; then dnl Visual C++ 2012 defaults to -arch:SSE2. Use -arch:IA32 dnl to avoid requiring SSE2. CFLAGS="$CFLAGS -arch:IA32" fi ;; esac Which solution do you prefer?
Attachment #8467779 -
Flags: review?(dmajor)
Flags: needinfo?(wtc)
Comment 3•9 years ago
|
||
Attachment #8467950 -
Flags: superreview?(kaie)
Attachment #8467950 -
Flags: review?(dmajor)
Updated•9 years ago
|
Attachment #8467950 -
Flags: superreview?(kaie) → superreview+
Comment 4•9 years ago
|
||
Comment on attachment 8467950 [details] [diff] [review] NSS patch Patch checked in: https://hg.mozilla.org/projects/nss/rev/dc69e3911326
Attachment #8467950 -
Flags: checkin+
Attachment #8467950 -
Flags: review?(dmajor) → review+
Comment on attachment 8467779 [details] [diff] [review] NSPR patch Either approach sounds fine, thanks for the patches!
Attachment #8467779 -
Flags: review?(dmajor) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8467779 [details] [diff] [review] NSPR patch Patch checked in: https://hg.mozilla.org/projects/nspr/rev/42d9fa709ca2
Attachment #8467779 -
Flags: checkin+
Thanks, I'll add the top-level and JS configures when I get a chance.
Comment 8•9 years ago
|
||
Comment on attachment 8467779 [details] [diff] [review] NSPR patch Regenerated nspr/configure: https://hg.mozilla.org/projects/nspr/rev/1a9eb31b1e6f
Comment 9•9 years ago
|
||
Comment on attachment 8467779 [details] [diff] [review] NSPR patch NSPR patch pushed to mozilla-inbound as part of the NSPR_4_10_7_BETA4 tag: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8cee47432c
Updated•9 years ago
|
Comment 10•9 years ago
|
||
Comment on attachment 8467950 [details] [diff] [review] NSS patch NSS patch pushed to mozilla-central as part of the NSS_3_17_BETA2 tag: https://hg.mozilla.org/mozilla-central/rev/07b8619be3bb
Updated•9 years ago
|
Keywords: leave-open
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc8cee47432c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
![]() |
Assignee | |
Comment 12•9 years ago
|
||
We still need the main and JS configure files.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
![]() |
Assignee | |
Comment 13•9 years ago
|
||
Assignee: wtc → dmajor
Attachment #8472124 -
Flags: review?(mh+mozilla)
Updated•9 years ago
|
Attachment #8472124 -
Flags: review?(mh+mozilla) → review+
![]() |
Assignee | |
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/709185909884
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/709185909884
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
QA Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•