1043128 - Variable LIBS is defined in Makefile, should only be defined in moz.build files

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Clean directory from inbound, mozconfig looks like:

  # disable conversion warning on 64-bit builds
  export CFLAGS="-wd4267"
  export CXXFLAGS="-wd4267"
  
  . $topsrcdir/browser/config/mozconfig
  
  ac_add_options --enable-optimize
  ac_add_options --enable-debug="-Z7 -d2Zi+"
  ac_add_options --target=x86_64-pc-mingw32
  ac_add_options --host=x86_64-pc-mingw32

Configured with:

  MOZCONFIG=../fc/fx64-debug ../inbound/configure

I get:


vladimir@shepherd[724]$ mozmake -s -j8
c:/proj/moz/inbound/config/config.mk:105: *** Variable LIBS is defined in c:/proj/moz/fx64-debug-inbound/Makefile. It should only be defined in moz.build files.  Stop.
vladimir@shepherd[725]$ grep LIBS Makefile
vladimir@shepherd[726]$ pwd
/c/proj/moz/fx64-debug-inbound

???  First time I've seen this.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I *think* I only get this without --disable-tests.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

No, --disable-tests doesn't make a difference.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It's likely bug 1036894 is to blame.

Comment 4

[Gregory Szorc [:gps]]

I haven't heard any reports of this in a few years. Assuming it was fixed elsewhere.