Closed Bug 1043128 Opened 6 years ago Closed 3 years ago

Variable LIBS is defined in Makefile, should only be defined in moz.build files

Categories

(Firefox Build System :: General, defect, major)

x86
Windows 8.1
defect
Not set
major

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: vlad, Unassigned)

References

Details

Clean directory from inbound, mozconfig looks like:

  # disable conversion warning on 64-bit builds
  export CFLAGS="-wd4267"
  export CXXFLAGS="-wd4267"
  
  . $topsrcdir/browser/config/mozconfig
  
  ac_add_options --enable-optimize
  ac_add_options --enable-debug="-Z7 -d2Zi+"
  ac_add_options --target=x86_64-pc-mingw32
  ac_add_options --host=x86_64-pc-mingw32

Configured with:

  MOZCONFIG=../fc/fx64-debug ../inbound/configure

I get:


vladimir@shepherd[724]$ mozmake -s -j8
c:/proj/moz/inbound/config/config.mk:105: *** Variable LIBS is defined in c:/proj/moz/fx64-debug-inbound/Makefile. It should only be defined in moz.build files.  Stop.
vladimir@shepherd[725]$ grep LIBS Makefile
vladimir@shepherd[726]$ pwd
/c/proj/moz/fx64-debug-inbound

???  First time I've seen this.
I *think* I only get this without --disable-tests.
No, --disable-tests doesn't make a difference.
Severity: normal → major
I haven't heard any reports of this in a few years. Assuming it was fixed elsewhere.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.