1043259 - Include address bar searches in local search history

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, enhancement, P3)

Description

[Matthew N. [:MattN]]

Searches from the address bar should be included in form history for the field "searchbar-history" for parity with the other search boxes (e.g. searchbox, about:home, about:newtab).

Examples:
* engine alias searches
* bookmark keyword searches
* plain search terms in the address bar that we ended up searching for

Perhaps all search entry points should get this? e.g. context menu, command line, etc.?

Comment 1

[:Paolo Amadini]

We'll probably need some processing, for example in the address bar you could search for "?mozilla" and this results in a search for the "mozilla" terms (which is what we should have in history).

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The code that does this for the search bar is here:

https://hg.mozilla.org/mozilla-central/annotate/d92db71d4e67/browser/components/search/content/search.xml#l497

I think we just need to copy that code to somewhere where we currently detect that we're doing keyword searches. I think there are two options:

https://hg.mozilla.org/mozilla-central/annotate/d92db71d4e67/browser/components/nsBrowserGlue.js#l355
https://hg.mozilla.org/mozilla-central/annotate/d92db71d4e67/browser/base/content/browser.js#l728

This should help avoid the issue from comment 1.

I'll need to think about which spot is best. If anyone is interested in picking this up, please needinfo me and I can look into it with you.

Comment 3

[Marco Bonardo [:mak]]

This was implemented as part of recent Search Suggestions improvement work, IIRC in bug 1398416.