Closed Bug 1043297 Opened 10 years ago Closed 8 years ago

"NoSquint" add-on does not zoom in e10s window

Categories

(Firefox :: Extension Compatibility, defect)

34 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
e10s + ---

People

(Reporter: ale160382, Unassigned)

References

Details

(Keywords: addon-compat)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140723030202

Steps to reproduce:

no squint not working with es10


Actual results:

no squint not working with es10 window
Blocks: e10s-addons
Component: Untriaged → Extension Compatibility
Summary: no squint not working with es10 → no squint not working with e10s
See Also: → 1014227
Talked to the developer of NS and at the moment he hasn't the time or desire to update it at all.  Unless he changes his mind someone else needs to update it to work with e10s or possibly take ownership of it if he let's them.

I find NS indispensable for those of us running HiDPI. Setup properly it will help to mitigate blurry graphics caused by running the OS at greater than 96dpi.
Gary, thanks for reaching out to the developer of NoSquint. The add-on is open source, so maybe someone can contribute an e10s fix. I think the fix would be pretty straightforward.

https://github.com/jtackaberry/nosquint

btw, here is the JS error I see in Firefox's Browser Console when I click the NoSquint toolbar buttons:

> TypeError: this.docShell is null browser.xml:409
Blocks: 1014227
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: addon-compat
See Also: 1014227
Summary: no squint not working with e10s → "NoSquint" add-on does not zoom in e10s window
hi Jason, if you have any questions about add-on support for multiprocess Firefox (e10s), just drop by the #e10s IRC channel on irc.mozilla.org. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox
Thanks Chris for adding me to this bug.  Just wanted to ack that I've seen it and understand NoSquint breaks with e10s.  I'll do my best to get ahead of e10s's becoming default in the stable releases, if not beta.
While you're at it, you might want to break the dependency on the now defunct status bar. It needs a button that can show the current zoom level, as well as give direct access to all options.

I have to install Status 4 EVAR to use it correctly right now.
I have the current zoom level in the toolbar. (I think it is called that. It is where other things are like "home" and "cut".) I don't think I did anything special to get it there. I don't have a status bar.

But I too am completely dependent on this. It is perhaps more needed for older people. And it is why I have not tried e10s, even though I do use Nightly.

The functions of NoSquint are ALMOST all included in the various zoom settings already available (or at least those that WERE avaailable). How hard is to include everything, so that the add-on would not be needed?
(In reply to Jonathan Baron from comment #6)
> I have the current zoom level in the toolbar. (I think it is called that. It
> is where other things are like "home" and "cut".) I don't think I did
> anything special to get it there. I don't have a status bar.
> 
> But I too am completely dependent on this. It is perhaps more needed for
> older people. And it is why I have not tried e10s, even though I do use
> Nightly.
> 
> The functions of NoSquint are ALMOST all included in the various zoom
> settings already available (or at least those that WERE avaailable). How
> hard is to include everything, so that the add-on would not be needed?

That's the built in zoom, which will not show both text and page zoom, and will not let you click on it to change zoom options for site, or right click to get a quick menu. In fact, clicking on it will reset the zoom to 100%.
This appears to be working now without any issue.
(In reply to Jerod Lycett from comment #8)
> This appears to be working now without any issue.

Not for me. I can barely read what I am writing now.

And the no-squint settings were unchanged.
(In reply to Jonathan Baron from comment #9)
> (In reply to Jerod Lycett from comment #8)
> > This appears to be working now without any issue.
> 
> Not for me. I can barely read what I am writing now.
> 
> And the no-squint settings were unchanged.

Odd, uninstalling and reinstalling, now it does not work.
e10s is now the default in Aurora. Unfortunately NoSquint doesn't work and it also breaks the zoom. See bug #1014227. I sympathize with the developer, I know time is hard to come by. For now I've disabled e10s (Uncheck 'Enable multi-process Firefox Developer Edition') and NoSquint is working again.
Hi, Jason, how goes this? Do you need anything?
Flags: needinfo?(tack-bugzilla)
As of 47.0a1 (2016-01-29), nosquint does not work at all, either with or without e10s. ALL I NEED TO DO IS TO SET ZOOM TO 150% FOR EVERY SITE. I can set it for one site, but then it isn't even preserved when I come back to that after re-starting.

This is CRITICAL for me, and probably for many other people like me. I am a geek, but an old geek. More and more of us will be using browsers. I suppose I should report another bug, but I'm trying this one first.

Note that, when nosquint is enabled even the + and - buttons don't work. They work for individual sites when it is disabled.
Until No Squint is fixed, consider using Zoom Page:

https://addons.mozilla.org/en-US/firefox/addon/zoom-page/

It works fine w/ e10s.
(In reply to Samat Jain from comment #14)
> Until No Squint is fixed, consider using Zoom Page:
> 
> https://addons.mozilla.org/en-US/firefox/addon/zoom-page/
> 
> It works fine w/ e10s.

This works (so far). Thanks. I also found that, even without it and with e10s enabled (and my sidebar enabled, which somehow had gotten un-done), once I set a couple of pages to 150%, then that setting seemed to carry over to new ones, most of the time. But not this very page (bugzilla). But if I closed the browser and opened it again, I had to start over. That is not necessary with Zoom Page. Anyway, I'm set for now, but to a non-coder of Firefox it seems like an easy thing to do to allow a fixed zoom setting everywhere for everything. Then we wouldn't need any of these add-ons.
I had a free evening, so I decided to look at the new(ish) APIs that are compatible with e10s.  Let's just say it's been a long time since I've been this frustrated with development work.

Trying even the most basic examples from the documentation failed.

https://gist.github.com/jtackaberry/e43aa187da6b899e1c98

I am not sure what I'm doing wrong, or indeed if I am doing *anything* wrong, but unless I have a significant breakthrough in understanding, I'm afraid I won't have the necessary amount of time needed to fix NoSquint for e10s.

And here I was hoping for an easy fix. :)
(In reply to Jason Tackaberry from comment #16)
> I had a free evening, so I decided to look at the new(ish) APIs that are
> compatible with e10s.  Let's just say it's been a long time since I've been
> this frustrated with development work.

Thanks very much for trying. For me, No Squint did not even work anymore without e10s.

Happily, Zoom Page works. I should add that I did not understand the configuration options for Zoom Page. I found that it worked best if I used the default for everything except the options that required a number indicating the amount of zoom, which I just set to 150.

Perhaps this bug should be moved to "documentation". I will leave that to others.
E10s is off and I observe the following error.[Occurs with E10s Enabled & Disabled]
NoSquint Global Settings window does not close when applying the [OK] button.
1) Install NoSquint
2) access about:addons>Extensions and click the Preferences button for the addon
3) Click the Zooming tab
4) increase the % values and check the box for the 2 available options
5) Click OK
Expect: The settings are saved and the window closes
Actual: The window does not close, [OK] button does not funciton, must use the (X) button as a workaround
Version 	47.0a2
Build ID 	20160323004040
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
I have e10s turned off in 47.0a2 on Linux 32-bit. I am not able to get the dialogs to open in NoQuint now, and scaling will not apply unless I choose one of the menu options on the status bar. The error console shows the following:

ReferenceError: $ is not defined       cmd.js:139:13
TypeError: NSQ.storage is undefined    cmd.js:183:13

It looks to me like some parts aren't loading. Perhaps it it is all stuff that relies on JQuery, which seems to not be loading. 

This is enough for me to switch to the ESR version if this isn't fixed by release time. Heck, I'm already trying to transition ot Chrome, where at least there is a rudimentary text scaling addon that can work concurrently with page scaling. 

The developer is AWOL. So please, someone else work on it. It is a vital accessibility addon.
I graciously accept the rebuke regarding my absenteeism.

The sad truth is that I don't have the capability to maintain NoSquint anymore.  I tried to fix some of the regressions in the past months, but in what time I had, I spent most of it trying to sort out the changes, new APIs, which APIs were supported and going out of support, and I made very little tangible progress in the time I was able to spend.

The reality is that maintaining NoSquint requires more of me than I am able to allocate.  Consequently, I will be shuttering this addon. I've let it languish for too long.  The code has always been open source and will continue to be available on GitHub for anyone who wants to either fix it up or steal useful bits for another addon.
Flags: needinfo?(tack-bugzilla)
Reminder to the disgruntled: NoSquint is no longer a "vital accessibility addon". An excellent alternative is Zoom Page. I find that it works well with at most two changes from the default configuration (which does not zoom at all, so you have to change something):

1. Under "Zoom levels" set "Default zoom level" to whatever you want.

2. Set "Custom zoom level" to the same thing. Not sure this is needed.

I agree that something like this is needed, but we have it. Zoom Page works fine with e10s.
Thanks for that Jonathan.  I have also been recommending the Zoom Page extension.

I have officially closed the project and released the code to the public domain (relicensed from LGPL).

My deepest apologies for what in retrospect has ended up stringing the NoSquint userbase along for almost two years.  I had ventured into this territory with good intentions but I've npw accepted that it's time to take NoSquint off life support.

My thanks to all of you who have supported NoSquint and the wider accessibility add-on ecosystem.
Oh, please feel free to close this bug.  I don't have the right access.

BTW, a bit more here: https://www.urandom.ca/nosquint/
Closed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Zoom Pages may be enough for some people, but it is not a full replacement. It does not offer the ability to zoom both the page and text at the same time. The only features it offers over regular Firefox is adding a UI and allowing either text or page zoom to be set on a per site level. That and setting a default zoom level for all sites that is independent of your DPI settings. (And what a site is is fixed--unlike with NoSquint)

What made NoSquint work well is that you could first zoom so that the entire width of the screen is taken up by the page. Then, if the text was too small, you could zoom even more. You also could zoom out to get something to fit on a lower resolution screen (which a lot of sight impaired people have) and then increase the text so it is legible. 

I personally have to use a small screen, as I get dizzy if the screen takes up too much of my vision. (I actually use a 16:9 screen but add the letter boxing to make it 4:3). But I still want the text to be legible. With Zoom Pages, I am stuck compromising between text that I have to squint a bit to see, and not having to scroll.

It's okay for about 90% of what I do, but that other 10% was so much better with NoSquint.

------

So why am I saying all this? I know nothing I can do will make the former developer suddenly have time to work on the addon. But I do not want anyone who sees this bug and thinks they might be able to help to think that a full replacement has been found. 

(Is it typical to WONTFIX if the developer has abandoned the project? I thought Mozilla  only WONTFIXed bugs if no patches would be accepted.)

I have contacted the developer of Zoom Pages to see if he can add these features.
You need to log in before you can comment on or make changes to this bug.