1043379 - In tests of the search component, clean up at the end of tests instead of the beginning

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[:Paolo Amadini]

Some tests of the Toolkit search component modify the search service configuration, for example by adding new engines, and subsequent tests reset the configuration when they start.

Each test should clean up the environment at the end instead.

Comment 1

[Florian Quèze [:florian]]

I'm a bit confused by this report. Unless I'm missing something, the tests you are talking about are the xpcshell tests in toolkit/components/search, and xpcshell each run in their own process with their own temporary profile, so cleaning up at the end of the test isn't useful. Can you clarify what the actual problem is? Thanks!

Comment 2

[:Paolo Amadini]

(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> I'm a bit confused by this report. Unless I'm missing something, the tests
> you are talking about are the xpcshell tests in toolkit/components/search,

Yes.

> and xpcshell each run in their own process with their own temporary profile,

Are you sure each individual test runs with a different profile now? Maybe this wasn't true at the time I worked on this.

> so cleaning up at the end of the test isn't useful. Can you clarify what the
> actual problem is? Thanks!

The original context is in the second part of bug 1041534 comment 4. I think we normally register cleanup functions that operate at the end of test files, for every preference or environment change we make at the beginning. If this is not the case anymore, we can close this bug report.

Comment 3

[Florian Quèze [:florian]]

(In reply to :Paolo Amadini from comment #2)
> I think
> we normally register cleanup functions that operate at the end of test
> files, for every preference or environment change we make at the beginning.

I think we do this in browser chrome tests, not in xpcshell tests.