1043529 - email UI: "Load more messages" styling

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Dylan Oliver [:doliver]]

Update the styling of the button to load more messages. See design spec in bug 1028224.

Comment 1

[Edward Chen[:edchen]]

No testcase, I will check spec to verify new ui design directly.

Comment 2

[James Burke [:jrburke]]

Attachment: download-more.png

These are screenshots for the "download more messages" visual design that was specified in bug 1028224 comment 13.

There is also a "Loading Messages" element that is shown after pressing the "Load more messages", when messages are loading. I gave it the same visual treatment as this new "Load more messages" screen, and this screenshot shows how that looks.

However, you may not have wanted that, or want something different. If you do, please let me know and I can easily change it.

If you want to try it for yourself, here is an app zip of the branch:

http://jrburke.com/work/gaia/email-download-more.zip

Guide for screens in this image:

1) Shows "Load more messages"
2) Shows the "Loading Messages" that is shown after tapping "Load more messages"
3) Shows how it looks when switching to a new folder that has not been fetched yet.
4) Shows how it looks as messages start to appear in the list as a result of downloading.
5) Shows how it looks when there are no messages in the list.

(small implementation note: In order to get the alignment correct, I had to crop the existing download.png to be a tight crop, and named it download_trimmed, keeping the original download.png for use in the other areas it is used now, mainly for message_reader attachment purposes)

One thing I noticed is that I should change the casing for "Loading Messages" to be "Loading messages" to match the "Load more messages" casing. 

Any other changes you would like?

Comment 3

[Juwei Huang[:juwei]]

Good job!!! Looks nice!
As for "Load More Message", it should be title case, so "Load messages" is the correct one.
James could you please help to modify it as title case? Thank you!

Comment 4

[James Burke [:jrburke]]

Juwei: I modified the patch so that the strings are both title case: "Load More Messages" and "Loading Messages". 

If that is the last change that is needed, once you and :peko flip the ui-review? to ui-review+, I will ask for final dev review then land it.

Comment 5

[Juwei Huang[:juwei]]

Comment on attachment 8473344 [details]
download-more.png

No problem!

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8473344 [details]
download-more.png

Since got ui-review+ from Juwei and visual designer not available this week, going to proceed with dev review and landing.

Comment 7

[James Burke [:jrburke]]

Attachment: GitHub pull request

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8474657 [details] [review]
GitHub pull request

r=asuth by inspection and screenshots

Comment 9

[James Burke [:jrburke]]

Merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/8ebbf7ec80b4c6ab179f0c4c21d66d30ba4f348b

from pull request:
https://github.com/mozilla-b2g/gaia/pull/22224

Comment 10

[Edward Chen[:edchen]]

[Environment]
Gaia      e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko     https://hg.mozilla.org/mozilla-central/rev/daa84204a11a
BuildID   20140824160205
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
PASS