Closed
Bug 1043577
Opened 11 years ago
Closed 11 years ago
Remove PropertyDescArray stuff
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: evilpies, Assigned: evilpies)
References
Details
Attachments
(1 file, 1 obsolete file)
|
14.28 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
This makes FormatValue a little bit more useless, however this function should really be rewritten.
Attachment #8461774 -
Flags: review?(jimb)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8461774 [details] [diff] [review]
v1
Review of attachment 8461774 [details] [diff] [review]:
-----------------------------------------------------------------
It seems like these stack dumps are still usable. I don't think we should take out functionality just because it happens to land in OldDebugAPI.cpp.
Attachment #8461774 -
Flags: review?(jimb) → review-
|
Assignee | |
Comment 2•11 years ago
|
||
I have removed features from that before and nobody complained.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: nobody → evilpies
Attachment #8461774 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8461924 -
Flags: review?(jimb)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8461924 [details] [diff] [review]
v2
Review of attachment 8461924 [details] [diff] [review]:
-----------------------------------------------------------------
Nicely done. :)
Attachment #8461924 -
Flags: review?(jimb) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•11 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•