1043595 - [B2G][Camera] Camera capture button highlight animation is square.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Camera.txt

Description:
After the first picture or video is taken, for every subsequent picture taken, the capture button will animate with a square icon when pressed, instead of the original circle.  This is most apparent when taking a video, and the highlighted button remains onscreen for the duration of the recording.


Repro Steps:
1) Update a Flame to 20140724040205
2) Open the Camera app
3) Press the capture button several times to take a picture.


Actual:
After the first picture, the capture button animation will be square.


Expected:
The capture button animation will always be a circle.

Environmental Variables:
Device: Flame Master
Build ID: 20140724040205
Gaia: c72257b2d27135bfcd68e89dd584182797784016
Gecko: 06ac51c2b8a8
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Keywords: Camera, Icon, Button, Circle, Square, Animation, Transition

Repro frequency: 100%
See attached: logcat, screenshot

-----------------------------------------------------------------------

This issue does NOT occur on Flame 2.0.
The icon animation is always a circle.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140724000201
Gaia: 29266e18c35f4e72e35f1bba0e34f2fb6b995cc3
Gecko: 178fe2efc41d
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 1

[Martin Shuman [:Marty]]

Attachment: Camera_Button_Screenshot.png

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Nominating for 2.1, is a regression from 2.0 to 2.1 and is highly visible.

Requesting a regression window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
Build ID: 20140723085706
Gaia: 15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko: dfc1543c9c50
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140723123306
Gaia: 5458f73e319759543fddf7e96d7ece4d78318e32
Gecko: 5b53be9551bb
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken gecko & last working gaia - issue does NOT repro
Gaia: 15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko: 5b53be9551bb

First broken gaia &  last working gecko - issue DOES repro
Gaia: 5458f73e319759543fddf7e96d7ece4d78318e32
Gecko: dfc1543c9c50

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/15c84c943e41ad834640a45e1e1c2ac804168af7...5458f73e319759543fddf7e96d7ece4d78318e32

Caused by Bug 1038172 ?

Comment 4

[Joshua Mitchell (Inactive)]

possibly broken by bug 1038172 ?

Comment 5

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 6

[Wilson Page [:wilsonpage]]

[Blocking Requested - why for this release]:

When bug 1038172 lands on 'v2.0' then this patch will need to be uplifted.

Comment 7

[Wilson Page [:wilsonpage]]

Landed on 'master'

https://github.com/mozilla-b2g/gaia/commit/88ede549ed4e6641e1c11d19f36d8549fdcbc712

Comment 8

[Jason Smith [:jsmith]]

Blocking to avoid regression on uplift.

Comment 9

[Hema Koka [:hema]]

Based on CAF call on 8/7, this is not a blocker for 2.0. It is a regression caused from patch in 1038172 and has landed on master. Marking it fixed and "-" from blocker.