Closed
Bug 1043608
Opened 10 years ago
Closed 10 years ago
Metro widget code needs updating to maintain contract with APZ code
Categories
(Core Graveyard :: Widget: WinRT, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(3 files, 1 obsolete file)
3.90 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
18.61 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
5.65 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Bug 1009073 made a bunch of changes in the APZ code to clean up how events flow around. As part of that widget-side code has to change as well. At the time I made the necessary changes to B2G in TabChild, but neglected to make the necessary changes to Metro. Without these changes input events are generally going to be misbehaving a lot.
I also want to do this so we can un-block the people working on pointer events in bug 1036985, as Metro seems to be the only platform they have access to.
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #0)
> Bug 1009073 made a bunch of changes in the APZ code to clean up how events
> flow around.
Bug 1009733.
Assignee | ||
Comment 3•10 years ago
|
||
Oops, thanks!
Assignee | ||
Comment 4•10 years ago
|
||
Not sure if you want to review these changes or not...
Attachment #8462251 -
Flags: review?(jmathies)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8461902 -
Attachment is obsolete: true
Attachment #8462252 -
Flags: review?(jmathies)
Assignee | ||
Comment 6•10 years ago
|
||
To prevent out-of-order responses we need to flush responses in the long-tap handler. This required introducing a way to invoke MetroInput code from APZController.
Attachment #8462253 -
Flags: review?(jmathies)
Updated•10 years ago
|
Attachment #8462251 -
Flags: review?(jmathies) → review+
Comment 7•10 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> Created attachment 8462252 [details] [diff] [review]
> Part 2 - The rewrite to deal with APZ input requirements
This is going to take a little time to get through and test. I'm on pto today but will get to this over the weekend. Thanks for reworking this!
Comment 8•10 years ago
|
||
Comment on attachment 8462252 [details] [diff] [review]
Part 2 - The rewrite to deal with APZ input requirements
Generally looks correct, and some testing of touch input doesn't expose any major issues.
mochitest-metro appears to be broken at the moment - filed bug 1045727. So I can't run front end tests. R= all the same so we can get this work in.
Attachment #8462252 -
Flags: review?(jmathies) → review+
Updated•10 years ago
|
Attachment #8462253 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 9•10 years ago
|
||
I wasn't entirely sure if this was better to land on metro or m-i but I figured m-i was better because it didn't make sense to leave the old code lying around on central if it doesn't work with the new APZ code. It's also better to keep the metro tree as close to m-c as possible, so unless we do back-merges it's generally better to land on m-c first.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9bfd9765389
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea78d99118f7
https://hg.mozilla.org/integration/mozilla-inbound/rev/22a756462d5d
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9bfd9765389
https://hg.mozilla.org/mozilla-central/rev/ea78d99118f7
https://hg.mozilla.org/mozilla-central/rev/22a756462d5d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•