Closed Bug 1043672 Opened 10 years ago Closed 7 years ago

CompileOptions is too complicated

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1456220

People

(Reporter: jimb, Unassigned)

Details

Right now, we have an abstract base class (ReadOnlyCompileOptions) and two concrete classes (CompileOptions and OwningCompileOptions), to accommodate both owning and non-owning kinds of compilation option collections. In the end, though, all this is saving us is some string copies, and letting us use Rooted<...> vs. PersistentRooted<...>, when the latter isn't even that expensive (same size; a few more stores). We could get by perfectly well with a single CompileOptions that always owns the option values, uses PersistentRooted so as not to be MOZ_STACK_CLASS, and copies strings as needed.
Closing stale bug in favour of Bug 1456220.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.