1043782 - [NFC][Flame] Cannot detect correct tag type for Mifare-Classic tag

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Dimi Lee [:dimi]]

Tested with v122 image and also with latest central code 0724

MWC card should be a mifare-classic tag.
In libnfc-nci it will be detected as a Type2 tag with technology NFC-A.

By using Flame libnfc-nci will report it as an unknown tag type

Comment 1

[Dimi Lee [:dimi]]

Attachment: MWC card

Comment 2

[Dimi Lee [:dimi]]

Attachment: flame log

Comment 3

[Dimi Lee [:dimi]]

Attachment: nexus4 log

Comment 4

[Dimi Lee [:dimi]]

Hi Wesley,
  This bug will need vendor's help to check

Comment 5

[Francis Lee [:frlee]]

hi Dimi,

do you mind to test it once again with V123 base image? base image V123.zip: http://1drv.ms/1rCB954

hi Youlong,

could you please check this issue with NXP if necessary?

Comment 6

[Dimi Lee [:dimi]]

(In reply to Francis Lee [:frlee] from comment #5)
> hi Dimi,
> 
> do you mind to test it once again with V123 base image? base image V123.zip:
> http://1drv.ms/1rCB954
> 
> hi Youlong,
> 
> could you please check this issue with NXP if necessary?

Hi Francis,
  V123 doesn't work either.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni? Francis again as v123 seems not working still.

Comment 8

[Francis Lee [:frlee]]

already highlighted NFC related issues to T2M, waiting for partner's feedback. i have loop wesley and Dimi in the mail thread with T2M as well.

Comment 9

[Dimi Lee [:dimi]]

After checking with T2M. nfcd will require modification to support mifare card on flame device, so I will take this bug.

Comment 10

[Dimi Lee [:dimi]]

Attachment: Part1. Add pn547 library provided by NXP

This Library is for reading Mifare tag for Flame and is provided by NXP

Comment 11

[Dimi Lee [:dimi]]

Attachment: Part2. Add Makefile

use TARGET_DEVICE to decide if nfcd should build pn547 library

Comment 12

[Dimi Lee [:dimi]]

Attachment: Part3. Code clean up

Clean up code related to NfcTagManager

Comment 13

[Dimi Lee [:dimi]]

Attachment: Part4. Support Mifare classic for Flame

Implementation in this patch is referenced from example provided by NXP

Comment 14

[Dimi Lee [:dimi]]

Comment on attachment 8472218 [details] [diff] [review]
Part1. Add pn547 library provided by NXP

Checked with yoshi, pn547 library for mifare should not put inside nfcd. Remove review request.

Comment 15

[Vincent Chang[:vchang][changyihsin]]

Hi Dimi, do we need to ask partner support to put pn547 library in gonk?

Comment 16

[Dimi Lee [:dimi]]

(In reply to Vincent Chang[:vchang] from comment #15)
> Hi Dimi, do we need to ask partner support to put pn547 library in gonk?

Yes, but partner is still working on it

Comment 17

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8561985 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd

see comments on github.

Comment 19

[Dimi Lee [:dimi]]

Comment on attachment 8561985 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd

Address comment

Comment 20

[Dimi Lee [:dimi]]

update pull request to fix nits and rebase to latest code

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_nfcd/commit/16836b56e16e89670b83735bda6d02c5608cc083