1043821 - [LockScreen] Move passcode verification to other System components

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

According to Paul's opinion, LockScreen should not verify the passcode, but delegate to System. I would put it in LockScreenWindowManager first, and maybe we can find another better place to put it after this bug.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

This patch caused a minor visual regression: the passcode pad would play an animation to slide out while lock it again. However, to eliminate this regression needs some refactoring work, that is out of scope of this bug. So after discussed with Tim, I would fire another follow-up bug immediately, and solve the regression at that bug.

And this bug also resolve the Bug 1023218, because I need to do that to make the regression stable. Without the code, the regression sometime would occur, and the other times it would not.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

CI passed:

https://tbpl.mozilla.org/?rev=ce42ce12d73cd08b3aea2d448e4e40db165731da&tree=Gaia-Try

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/295967a0b824a355ae9d57fb08f3632ed2ad18dd

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Cannot verify this issue since bug 1043892 is still technically open even though it was resolved as fixed. The issue has been written up again with bug 1064630