1043846 - Remove toolkit/locales/en-US/chrome/formautofill/requestAutocomplete.dtd until it's needed

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

The patch to bug #1020865 has added a placeholder L10n file at toolkit/locales/en-US/chrome/formautofill/requestAutocomplete.dtd . This file doesn't contain any localizable strings, thus it seems a rather strange choice to add it to the repository. Please remove it until it is indeed needed and used.

Comment 1

[:Paolo Amadini]

Matt, are you fine with removing the file?

Comment 2

[Matthew N. [:MattN]]

Sure. I didn't really want to add it in the first place but on the other hand comment 0 doesn't describe any problem it's causing.

Comment 3

[Rimas Kudelis [use needinfo to ping]]

(In reply to Matthew N. [:MattN] from comment #2)
> Sure. I didn't really want to add it in the first place but on the other
> hand comment 0 doesn't describe any problem it's causing.

It's not causing any problems. It's just a bit weird to have a "localizable" file with nothing to localize. I'm having mixed feelings about whether or not I want to add a file like that to my locale repo: on one hand, if I add it, I'll hide a useless warning, but on the other hand, empty files are just pointless and I just don't like having them in my repo.

I talked to flod today, and he suggested that since it's already there, this file should NOT be removed from Aurora, so this bug only concerns Central. If you plan to add localizable strings to this file anytime soon, you may just wontfix this bug.

Comment 4

[Matthew N. [:MattN]]

(In reply to Rimas Kudelis from comment #3)
> on one hand, if I add it, I'll hide a useless warning,

I didn't know there was a warning for this somewhere. I guess that was the problem that you were looking on fixing.

Comment 5

[Francesco Lodolo [:flod]]

compare-locales, which runs the l10n dashboard, complains for a missing file, even if it's empty.

As Rimas said, if you plan to add new strings in this cycle on m-c, this should be wontfixed.

Comment 6

[Francesco Lodolo [:flod]]

Example for Fennec Aurora French (being in toolkit, the warning is for all products)
https://l10n.mozilla.org/dashboard/compare?run=420804

Comment 7

[Matthew N. [:MattN]]

This is getting fixed in attachment 8819095 [details].