1043971 - Implement specific event for Loop calls "on hold"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

When a call is put on hold, the phone putting the call on hold just stops sending video and audio and the other FxOS party will just stop seeing and listening to the one putting the call on hold. 

We are going to send another custom event in that case so we can show a more sophisticated UI (something like “the call is on hold”). 

For doing that we will user Tokbox signaling API.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/59

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8462612 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/59

The plumbing for the signaling between peers is ready. I'm wondering if we would need also a 'resume' notification once the call is resumed. Would we need it? Please, have a look at what we have implemented so far.

Comment 3

[Borja Salguero [:borjasalguero]]

In this case we would need 'resume' as well (we could do tracking the status of the video/audio stream, but I would like not to do in this way).

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Borja Salguero [:borjasalguero] from comment #3)
> In this case we would need 'resume' as well (we could do tracking the status
> of the video/audio stream, but I would like not to do in this way).

Well, I'll add the resume signal as well. Clearing the ni? at ferjm then.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> Well, I'll add the resume signal as well. Clearing the ni? at ferjm then.

I already added it to the PR. Waiting for visuals to show when the call is held and resuming the call.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/92

Finally I manged to see this working. It's been quite a pain due the tokbox signaling mechanism. Borja, would you mind to have a look please? Thanks!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Thanks Borja, landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/449ce35c237c52d588f5ac23aad911ce5bf2d18f