1044066 - [Stingray] Zoom in/out support for browser on non-touch-enabled devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

For non-touch-enabled devices, we cannot use pinch gesture to perform APZ zoom in/out while browsing web page. We need a way to trigger zoom in/out UI like Firefox browser (click button or key event).

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: zoom-browser-api.patch

I tried to add a browser API for zoom in/out by leverage nsIContentViewer.fullZoom. However, the following JS error is shown while modifying fullZoom attribute in BrowserElementChildPreload.js.
>System JS : ERROR chrome://global/content/BrowserElementChildPreload.js:1036 - NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative

Is this the right way to provide zoom in/out functionality?

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: zoom-browser-api.patch

The fullZoom attribute is recently moved from nsIMarkupDocumentViewer to nsIContentViewer and my codebase doesn't catch up with this modification. This patch works after update my codebase to latest m-c tip.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: gaia-example.patch

This is the sample code of how gaia can use the zoom API.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8462988 [details] [diff] [review]
zoom-browser-api.patch

Review of attachment 8462988 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementParent.jsm
@@ +591,5 @@
>    _stop: function() {
>      this._sendAsyncMsg('stop');
>    },
>  
> +  _zoom: function(zoom) {

can you add a comment with the allowed value range for zoom?
Also, we likely want to validate the value here and/or in the child.

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: zoom-browser-api.patch, v2

Gecko already defined two preferences for the valid zoom scale (zoom.minPercent/zoom.maxPercent) [1], so I use it to clip the zoom scale given in argument.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/events/EventStateManager.cpp#1955

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: zoom-browser-api.patch

update commit log, carry r+.

try looks good: https://tbpl.mozilla.org/?tree=Try&rev=65be9f765f3a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1727c4616c4d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1727c4616c4d