Upgrade mercurial version 2.5.3 -> 2.6.3 for running unit tests (in requirements.txt)

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pmoore, Assigned: pmoore)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I'm setting up unit testing for vcs sync in mozharness.

In order to set up unit tests to run locally, I ran:

pip install -r requirements.txt

from the top level mozharness directory. However, the requirements.txt file references mercurial version 2.5.3, which is no longer available on pypi.python.org:

$ pip install -v mercurial-2.5.3
Downloading/unpacking mercurial-2.5.3
  Could not fetch URL https://pypi.python.org/simple/mercurial-2.5.3/: HTTP Error 404: Not Found
....
....
DistributionNotFound: No distributions at all found for mercurial-2.5.3


The version we are using in vcs sync is 2.6.3, e.g.: http://hg.mozilla.org/build/mozharness/file/1e967aaaa3b0/configs/vcs_sync/beagle.py#l586

Therefore I'd like to upgrade the version in the requirements.txt file from 2.5.3 -> 2.6.3 also.

Pete
(Assignee)

Comment 1

3 years ago
Created attachment 8462701 [details] [diff] [review]
bug1044116_mozharness_v1.patch
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Attachment #8462701 - Flags: review?(escapewindow+mozbugs)

Comment 2

3 years ago
Comment on attachment 8462701 [details] [diff] [review]
bug1044116_mozharness_v1.patch

Try it.
There may be some unit.sh errors due to the code assuming an older hg, but really those are bugs that should be fixed.

My mozharness venv has hg 1.7.3, which passes all tests.  I've been thinking about getting it hg bleeding-edge compatible, but never needed to prioritize that.
Attachment #8462701 - Flags: review?(escapewindow+mozbugs) → review+
(Assignee)

Comment 3

3 years ago
Thanks Aki!

Seems to pass ok:


(mozharness-tests)pmoore@Elisandra:~/git/mozharness master $ ./unit.sh 
### Finding mozharness/ .py files...
### Finding scripts/ .py files...
### Running pyflakes
mozharness/base/vcs/mercurial.py:47: list comprehension redefines 'p' from line 42
### Running pylint
### Testing non-networked unit tests
..................................................S.......S...........................................................................................................
----------------------------------------------------------------------
Ran 166 tests in 54.694s

OK (SKIP=2)
### Running *.py [--list-actions]
### Running scripts/configtest.py --log-level warning
### Creating coverage html


So I'll land the change...

Pete
(Assignee)

Comment 4

3 years ago
Comment on attachment 8462701 [details] [diff] [review]
bug1044116_mozharness_v1.patch

Landed on default: https://hg.mozilla.org/build/mozharness/rev/6a94edafe64d
Attachment #8462701 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.