1044172 - [Regression] Error "aJID.trim is not a function" when deleting XMPP account

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Timestamp: 26/07/14 12:19:34 am
Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "aJID.trim is not a function" {file: "resource:///modules/xmpp.jsm" line: 1001}]'[JavaScript Error: "aJID.trim is not a function" {file: "resource:///modules/xmpp.jsm" line: 1001}]' when calling method: [prplIAccount::remove]
Source File: resource://gre/components/imAccounts.js
Line: 621

This happens when I try to delete an XMPP account (both generic and GTalk, but not Facebook), regardless of whether the account is connected. The account does not get deleted, and I ended up with a duplicate of the GTalk account I tried to delete after my first attempt, though I cannot reproduce this. After restarting Instantbird the passwords for these accounts seemed to have been forgotten. I currently have no way to delete these accounts.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8462763 [details] [diff] [review]
Patch

Review of attachment 8462763 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the issue, thanks!

Comment 3

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/74fe45baef1e