Closed Bug 1044195 Opened 11 years ago Closed 10 years ago

frontend projects throw window.navigation.l10n is undefined if the locale file hasn't been generated

Categories

(Marketplace Graveyard :: Curation Tools, defect, P1)

Product:
Marketplace Graveyard
Component:
Curation Tools
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-03-24

People

(Reporter: krupa.mozbugs, Assigned: kngo)

References

(
URL
)

Details

(Whiteboard: [ktlo])

steps to reproduce: 1. Load https://marketplace-dev.allizom.org/curate/?lang=fr actual behavior: Curation tool doesn't load in fr due to TypeError: e.navigator.l10n is undefined
Assignee: nobody → charmston
https://github.com/mozilla/transonic/compare/9195c006d500...d0b4f763821e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
I now see the js error TypeError: window.navigator.l10n is undefined
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Severity: normal → trivial
It appears that it is being deployed with: https://github.com/mozilla/zamboni/blob/master/mkt/commonplace/templates/commonplace/index.html Instead of: https://github.com/mozilla/transonic/blob/master/src/index.html I don't know enough about commonplace deployments to understand how or why this is happening. Jason, Kevin, cvan, any of you have insight as to that is?
Flags: needinfo?(jthomas)
It's on purpose, index.html files in commonplace projects are only used by the damper. In production/dev/stage we use zamboni's commonplace/index.html. To fix the same issue in discoplace, I generated .po files every locale we support. See https://github.com/mozilla/discoplace/commits/master/locale
Flags: needinfo?(jthomas)
Assignee: charmston → nobody
Blocks: Feed_OnDeck
No longer blocks: 1033040
Scott no parlez vous francais
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → WONTFIX
Affecting op dashboard.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Summary: Curation tool doesn't load in fr due to TypeError: e.navigator.l10n is undefined → frontend projects throw window.navigation.l10n is undefined if the locale file hasn't been generated
Assignee: nobody → kngo
Severity: trivial → normal
Priority: P5 → P1
Target Milestone: --- → 2015-03-17
https://github.com/mozilla/marketplace-core-modules/pull/30 This will be pulled into op-dashboard and curation tools when they've been updated to mcm v2.x.x.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Thanks, Kevin. Does this mean it will go into effect after next Tuesday's push?
Yeah, I have to do a bit of follow-up work, but it will make the tag to go out on Tuesday.
Verified in FF39(win7) in marketplace-dev.allizom.org Issue is still reproducing, please view this screencast: http://screencast.com/t/af7wkR1tGQ Closing bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It was regression from mcm bump: https://github.com/mozilla/transonic/commit/8c7ffd28781df69824af0c92bb1e44cd6767b7d0
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Verified as fixed in FF39(Win7) in marketplace-dev.allizom.org Postfix screencast: http://screencast.com/t/mDWNIX7G4A Closing bug.
Status: RESOLVED → VERIFIED
Hi, I've seen that this issue has been solved last Friday, can you please confirm when this is going to be uplifted? This is a very critical issue for LatAm countries. Most of staff in carriers use platformed computers (i.e. not able to modify settings or install anything), so most of the computers accessing to Operator Shelf tools are going to be configured in Spanish. Thanks! David
I can see the Issue reproducing again in production: http://screencast.com/t/sXBfck7lx Yesterday when I checked on mp-dev it wasn't reproducing. Kevin do you know if this fix was cherry picked?
Flags: needinfo?(kngo)
This has been resolved and uplifted for the Operator Shelf Tools. It has not been uplifted for the curation tools this week, but that is not a big deal.
Flags: needinfo?(kngo)
Hi Kevin, Do you know when we're expecting the uplift? Cheers, David
Flags: needinfo?(kngo)
It has been uplifted to Operator Shelf Tools yesterday.
Flags: needinfo?(kngo)
Hi Kevin, I've tried this today (couple of hours ago) and I was still seeing the issue. Can you please do a retest? Some colleagues from the carrier partner was also experiencing this today. Cheers! David
Thanks so much for reporting. We're having a cache issue with the CDN, we will get that resolved promptly. I will comment again once it is resolved.
It seems we have a race condition that appears on Prod, but not Dev. I've been working on a fix for this fortunately. I don't think we can get this out before next Tuesday since it requires a lot of code moving around. In the meantime, can you tell the users to go to https://marketplace.firefox.com/operators/?lang=en-US as a workaround? Attaching /?lang=en-US should fix this.
Status: VERIFIED → REOPENED
Flags: needinfo?(dpalomino.bugzilla)
Resolution: FIXED → ---
Flags: needinfo?(dpalomino.bugzilla)
https://github.com/mozilla/marketplace-core-modules/pull/32 https://github.com/mozilla/marketplace-gulp/pull/17 https://github.com/mozilla/fireplace/pull/1083
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: 2015-03-17 → 2015-03-24
Issue is not reproducing in mp-dev. As per comment 22 we will close this bug only after we make sure that this is working properly on production too.
Hi, We've been testing this again, and now it's working fine when the browser is configured in other languages. Thanks a lot! David
Status: RESOLVED → VERIFIED
Glad it's working, David! I'm going to move it back from verified to resolved—we typically reserve that for QA.
Status: VERIFIED → RESOLVED
Closed: 10 years ago → 10 years ago
Whiteboard: [ktlo]
You need to log in before you can comment on or make changes to this bug.