1044227 - Search is not returning e.me results

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Zac C (:zac)]

This has caused e.me to stop appearing in the search results. Search suggestions are not showing, too. 

STR:
1. Fly to the USA (may not be required)
2. Connect to wifi
3. Search for 'viamichelin'

Actual: No e.me results are shown, search suggestions are not shown.


Last good:
Gaia      895268b9322a2e2567c5c96a05396c8723816f58
Gecko     https://hg.mozilla.org/integration/b2g-inbound/rev/f30f74b03446
BuildID   20140724062406
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

First Failing:
Gaia      e80dc912903ecafbeff4229af5d6bd4daaf7812b
Gecko     https://hg.mozilla.org/integration/b2g-inbound/rev/78de0ccff135
BuildID   20140724064907
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Zac C (:zac)]

NB - don't press Enter, just type "viamichelin" and wait for the icons to appear.

Comment 2

[Zac C (:zac)]

Attachment: search_fail.log

Comment 3

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

Comment 4

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #3)
> [Blocking Requested - why for this release]:

Smoketest blocker.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: search suggestions are also not showing.

Comment 6

[Jason Smith [:jsmith]]

Flagging qablocker since this is causing a permafail on one of the automated tests.

Comment 7

[Kevin Grandon :kgrandon]

Need to get around to adding a test for this =/ We have one for verticalhome, should not be hard to adopt for the search bar. If you're fixing this in-place, please add a test, or file a follow-up to add a test. Thanks.

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22182

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8462841 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22182

Code makes sense. r=me with the caveat that we file a follow up bug to add a test as per comment 7.

Comment 10

[Peter Bylenga [:PBylenga]]

I see the window now in Comment 0, striking request.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/55f572eb4db14d9d1cc026f7f218c595535d0752

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Michael Henretty [:mhenretty] from comment #9)
> Comment on attachment 8462841 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/22182
> 
> Code makes sense. r=me with the caveat that we file a follow up bug to add a
> test as per comment 7.

Did we file a bug to add the test?

Comment 13

[Kevin Grandon :kgrandon]

(In reply to Kevin Grandon :kgrandon from comment #12)
> (In reply to Michael Henretty [:mhenretty] from comment #9)
> Did we file a bug to add the test?

We should be fine with bug 1044364 and bug 993652 fixed.

Comment 14

[Kevin Grandon :kgrandon]

Re-enabled test as this has been resolved and travis is now showing an "unexpected success".

https://github.com/mozilla-b2g/gaia/commit/f0c7c212dd1ab128b8d2583e7629112634c26243

Comment 15

[Josh Schmitt [Joshs]]

I am no longer seeing this issue on latest 2.1

Environmental Variables:
Device: Flame Master
Build ID: 20140728040209
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: a4dcfbebcb58
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0