1044365 - return value of console evaluation should be shown after any console logs from the code executed

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[ColCh]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

Just try to log simple stuff:

JS code to execute in console:

var a = 10; console.log(a); a = 20; a;




Actual results:

It displays return value at first. 

Result is: 

20
10


Expected results:

should show console.log. 


Result is: 

10
20

Comment 1

[ColCh]

Expected result - should show logging stuff in right order (just like execution order). Result should be "10, 20"

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1044365 - Do not force webconsole evaluation result to show up immediately after the input;r=vporof

Review commit: https://reviewboard.mozilla.org/r/28109/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28109/

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8698762 [details]
MozReview Request: Bug 1044365 - Do not force webconsole evaluation result to show up immediately after the input;r=vporof

https://reviewboard.mozilla.org/r/28109/#review25471

This looks good to me, but I'm not entirely confident reviewing webconsole frontend code, so you might want to pass this by panos as well.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8698762 [details]
MozReview Request: Bug 1044365 - Do not force webconsole evaluation result to show up immediately after the input;r=vporof

Additional request from Comment 3

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8698762 [details]
MozReview Request: Bug 1044365 - Do not force webconsole evaluation result to show up immediately after the input;r=vporof

https://reviewboard.mozilla.org/r/28109/#review25637

Since this behavior appears to exist since ancient times and I can't find any rationale for it, let's avoid all these complications and do the simple thing.

Comment 6

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d37bac6a649

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2903b0280572

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2903b0280572

Comment 10

[Forhad Hossain]

I have reproduced the bug in Nightly 34.0a1 (2014-07-25) on windows 7 32 bit comment 0

Bug is fixed now on Latest Developer Edition 46.0a2 (2016-03-05)(Build ID:20160305004010)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:46.0) Gecko/20100101 Firefox/46.0


[testday-20160304]

Comment 11

[Nazir Ahmed Sabbir [:NaSb]]

Successfully Reproduced this bug with Firefox Nightly 34.0a1 (2014-07-25) on Linux, 64 Bit with the instructions from comment 0 

This Bug is now verified as fixed Latest Firefox Developer Edition 46.0a2 (2016-03-05)

Build ID: 20160305004010
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0