Closed Bug 1044537 Opened 8 years ago Closed 5 years ago

Gear menu items on new tab page should have hover

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: manishearth, Assigned: manishearth)

References

Details

Attachments

(7 files)

On the newtab page, if you click on the gear, a Enhanced/Classic/Blank menu appears.

The items have no hover, which feels a bit strange. We probably should add one.
Any suggestions for what sort of hover to add (color, etc) if any? I'm thinking `rgba(80, 80, 80, 0.28);`, but I'll need to make it work well with the checkmark (which gets ovewritten)
Flags: needinfo?(ux-review)
Furtermore: If one zooms in/out in NewTab page and then clicks on the gear the context menu pops up away from the gear.
Manish - Let's go with your suggestion and see how it looks.

CAK - Can you please provide a screenshot? Not understanding what you mean. Thanks!
(In reply to Aaron from comment #3)
> CAK - Can you please provide a screenshot? Not understanding what you mean.
> Thanks!

Three attachments: 
1. No Zooming
2. Zoomed-In
3. Zoomed-Out

I should say that my preferences for NewTabPage in about:config are 10 rows x 10 columns
Attached image Gear-NoZoom.jpg
Attached image Gear-ZoomedIn.jpg
Attached image Gear-ZoomedOut.jpg
Attached image Icon_Cog_Static.svg
Please use this SVG at 100% for the static cog image
Attached image Icon_Cog_Rollover.svg
Please use this SVG at 100% for the rollover/active cog image
Clearing needinfo since Aaron has provided the assets.

CAK, could you file a separate bug about the detached menu? Thanks!
Flags: needinfo?(ux-review)
(In reply to Philipp Sackl [:phlsa] from comment #10)
> CAK, could you file a separate bug about the detached menu? Thanks!

Filed as Bug 1045528
(In reply to Aaron from comment #9)
> Created attachment 8463410 [details]
> Icon_Cog_Rollover.svg
> 
> Please use this SVG at 100% for the rollover/active cog image

Unfortunately, this icon looks quite blurry when scaled to the size of the button.
How about using the same blue that we have in the pin-buttons as hover and active color?
Flags: needinfo?(athornburgh)
See Also: → 1046693
Additionally, this bug is about the gear menu items (what you get when you click on the gear), not the gear itself. The bug about blurryness is bug 1046693.
Attached patch Add hoverSplinter Review
This patch should do it. I'll attach a screenshot in a moment.
Attachment #8465386 - Flags: review?(adw)
Attached image Screenshot of the hover
The blurriness is my fault (got some issues with gimp's screenshot feature), not a feature of the patch.
Attachment #8465387 - Flags: ui-review?(philipp)
Comment on attachment 8465386 [details] [diff] [review]
Add hover

Review of attachment 8465386 [details] [diff] [review]:
-----------------------------------------------------------------

The gear panel looks similar to the search panel popup that appears when you click the engine logo to the left of newtab's search bar (if the selected engine has a logo), so we should keep their styles in sync.  Bug 1037246 proposes some larger changes to the search panel, so assuming we want to make those changes, at the least this bug should match that style, but I think working on the search panel first would be better since it's probably more visible.
Attachment #8465386 - Flags: review?(adw)
Depends on: 1037246
I'm not sure what to review here. The blurryness is being dealt with in bug 1046693
Flags: needinfo?(manishearth)
(In reply to Philipp Sackl [:phlsa] from comment #17)
> I'm not sure what to review here. The blurryness is being dealt with in bug
> 1046693…

Have a look at the menu items when you click on the gear, I added a hover effect. But I think this bug will be on hold till bug 1037246 is finalized.
Flags: needinfo?(manishearth)
(In reply to Manish Goregaokar [:manishearth] from comment #18)
> (In reply to Philipp Sackl [:phlsa] from comment #17)
> > I'm not sure what to review here. The blurryness is being dealt with in bug
> > 1046693…
> 
> Have a look at the menu items when you click on the gear, I added a hover
> effect. But I think this bug will be on hold till bug 1037246 is finalized.

Ah, I finally understand what that bug is about! Sorry, that took a long time :)

You're actually dealing with a slightly larger issue here. The popups on the new tab page look different than the popups elsewhere (e.g. the bookmarks menu http://cl.ly/image/1j14082c0E0I). We should generally switch to the styling of the bookmarks menu here – that way we'd also have a hover effect.
Yeah, there are two rather similar bugs, and they're getting confused for each other ;)
Flags: needinfo?(athornburgh)
The tab items now have a hover; unsure when this was fixed, but it's been three years so it probably was fixed as part of another UI patch  ¯\_(ツ)_/¯
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.